test: remove obsolete terraform test, fix stale sentry-release assertion - #6902
Merged
Conversation
test/unit/root-terraform-grafana-firewall.test.ts read terraform/main.tf, terraform/variables.tf, and terraform/README.md -- all deleted by commit 9001197 ("chore: remove unused terraform/ directory"), whose message confirms this was deliberate and discussed with the repo owner ("Never applied... no intention of using terraform/Hetzner going forward"). The test guarded real safety-critical invariants (Grafana's firewall port never opened to the public) for a module that no longer exists, so it's pure dead code now -- removed rather than updated, since there's nothing left to test. The miner's separate Terraform module (packages/loopover-miner/terraform/) is untouched and still has its own test. test/unit/selfhost-sentry-release.test.ts asserted scripts/deploy-selfhost-prebuilt.sh still defaults SENTRY_RELEASE to the pre-rename "gittensory-selfhost@..." prefix; the script itself has already moved to "loopover-selfhost@...". Every other assertion in this test (40+, covering the release workflow's Docker image naming, Sentry API calls, and version-tag handling) was already correct and unaffected -- only this one stale expected value needed updating to match reality. Also regenerates scripts/branding-drift-baseline.json: unrelated to this change, but picked up while re-verifying against a moving main -- a separate, concurrent rebrand PR removed a "gittensory" comment mention in packages/loopover-mcp/bin/loopover-mcp.js without regenerating the baseline, so the regression-guard test in check-branding-drift-script.test.ts was failing on main itself. Confirmed via git blame/content inspection that both original failures were unrelated to any of this session's other PRs (verified real CI logs on #6900, which surfaced these same 2 pre-existing failures despite never touching either file).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6902 +/- ##
===========================================
+ Coverage 82.29% 93.70% +11.40%
===========================================
Files 685 685
Lines 68284 68284
Branches 18715 18715
===========================================
+ Hits 56195 63985 +7790
+ Misses 9613 3302 -6311
+ Partials 2476 997 -1479
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 task
jeffrey701
pushed a commit
to jeffrey701/gittensory
that referenced
this pull request
Jul 17, 2026
Sweeps the rest of test/ for lingering pre-rename "gittensory" text that PR JSONbored#6900 didn't already cover -- arbitrary example values, prose comments, and non-functional identifiers with no behavioral dependency on the real GITHUB_APP_SLUG or LOOPOVER_REVIEW_REPOS defaults. Purely 1:1 string swaps, no logic changes. Verified via three full unsharded npm run test:coverage passes. The first (before rebasing onto JSONbored#6900/JSONbored#6902) was green on a stale base. After reconciling onto the new origin/main, the second surfaced 3 files (rag-index.test.ts, reputation-wiring.test.ts, ci-completion-fork-resume.test.ts) where the renamed repo identity happened to be the SAME value load-bearing against LOOPOVER_REVIEW_REPOS's still-current "JSONbored/gittensory,acme/widgets" allowlist default -- reverted those three back to "gittensory" to keep the allowlist match, matching the same reasoning JSONbored#6900 already applied to GITHUB_APP_SLUG-dependent fixtures. The third run confirmed clean: 949 files, 18084 tests, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/root-terraform-grafana-firewall.test.tsreadterraform/main.tf,terraform/variables.tf, andterraform/README.md-- all deleted by commit9001197c("chore: remove unused terraform/ directory"), whose message confirms this was deliberate and discussed with the repo owner ("Never applied... no intention of using terraform/Hetzner going forward"). The test guarded real safety-critical invariants (Grafana's firewall port never opened to the public, opt-in exposure) for a module that no longer exists, so it's pure dead code now -- removed rather than updated, since there's nothing left to test. The miner's separate Terraform module (packages/loopover-miner/terraform/) is untouched and still has its own test (test/unit/self-host-ops-rename-residue.test.ts).test/unit/selfhost-sentry-release.test.tsassertedscripts/deploy-selfhost-prebuilt.shstill defaultsSENTRY_RELEASEto the pre-rename"gittensory-selfhost@..."prefix; the script itself has already moved to"loopover-selfhost@...". Every other assertion in this test (40+, covering the release workflow's Docker image naming, Sentry API calls, and version-tag handling) was already correct and unaffected -- only this one stale expected value needed updating to match reality.scripts/branding-drift-baseline.json: unrelated to this change in origin, but picked up while re-verifying against a movingmain-- a separate, concurrent rebrand PR removed a "gittensory" comment mention inpackages/loopover-mcp/bin/loopover-mcp.jswithout regenerating the baseline, so the regression-guard test incheck-branding-drift-script.test.tswas failing onmainitself.git blame/content inspection, then confirmed again against real CI logs on fix(test): rename the stale gittensory GITHUB_APP_SLUG default to loopover-orb #6900 (which surfaced these exact same 2 pre-existing failures despite never touching either file).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally -- test-only change (plus a regenerated baseline JSON), which Codecov does not measure undertest/**, so there is no patch-coverage obligation.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateAdditional validation: a full local
npm run test:cirun is green with this change (all steps, zero failures).Safety
UI Evidencesection below. (Not applicable -- no visible/UI changes.)UI Evidence
Not applicable -- test-only change, no UI/frontend/docs surface touched.
Notes
mainitself. This PR fixesmain, benefiting every other currently-open PR too.