Skip to content

test: remove obsolete terraform test, fix stale sentry-release assertion - #6902

Merged
JSONbored merged 1 commit into
mainfrom
worktree-terraform-sentry-drift-cleanup
Jul 17, 2026
Merged

test: remove obsolete terraform test, fix stale sentry-release assertion#6902
JSONbored merged 1 commit into
mainfrom
worktree-terraform-sentry-drift-cleanup

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • test/unit/root-terraform-grafana-firewall.test.ts read terraform/main.tf, terraform/variables.tf, and terraform/README.md -- all deleted by commit 9001197c ("chore: remove unused terraform/ directory"), whose message confirms this was deliberate and discussed with the repo owner ("Never applied... no intention of using terraform/Hetzner going forward"). The test guarded real safety-critical invariants (Grafana's firewall port never opened to the public, opt-in exposure) for a module that no longer exists, so it's pure dead code now -- removed rather than updated, since there's nothing left to test. The miner's separate Terraform module (packages/loopover-miner/terraform/) is untouched and still has its own test (test/unit/self-host-ops-rename-residue.test.ts).
  • test/unit/selfhost-sentry-release.test.ts asserted scripts/deploy-selfhost-prebuilt.sh still defaults SENTRY_RELEASE to the pre-rename "gittensory-selfhost@..." prefix; the script itself has already moved to "loopover-selfhost@...". Every other assertion in this test (40+, covering the release workflow's Docker image naming, Sentry API calls, and version-tag handling) was already correct and unaffected -- only this one stale expected value needed updating to match reality.
  • Also regenerates scripts/branding-drift-baseline.json: unrelated to this change in origin, but picked up while re-verifying against a moving main -- a separate, concurrent rebrand PR removed a "gittensory" comment mention in packages/loopover-mcp/bin/loopover-mcp.js without regenerating the baseline, so the regression-guard test in check-branding-drift-script.test.ts was failing on main itself.
  • Both original failures were confirmed unrelated to any of this session's other PRs via git blame/content inspection, then confirmed again against real CI logs on fix(test): rename the stale gittensory GITHUB_APP_SLUG default to loopover-orb #6900 (which surfaced these exact same 2 pre-existing failures despite never touching either file).

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves -- not applicable; this is a maintainer-authored cleanup fixing pre-existing test drift, not a contributor PR under the linked-issue policy.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally -- test-only change (plus a regenerated baseline JSON), which Codecov does not measure under test/**, so there is no patch-coverage obligation.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries -- not applicable; no production code changed, this only removes a test for deleted infrastructure and corrects one stale string assertion.

Additional validation: a full local npm run test:ci run is green with this change (all steps, zero failures).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics. (Not applicable -- test-only change.)
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. (Not applicable -- no such changes.)
  • API/OpenAPI/MCP behavior is updated and tested where needed. (Not applicable -- no such changes.)
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. (Not applicable -- no UI changes.)
  • Visible UI changes include a UI Evidence section below. (Not applicable -- no visible/UI changes.)
  • Public docs/changelogs are updated where needed. (Not applicable.)

UI Evidence

Not applicable -- test-only change, no UI/frontend/docs surface touched.

Notes

test/unit/root-terraform-grafana-firewall.test.ts read terraform/main.tf,
terraform/variables.tf, and terraform/README.md -- all deleted by commit 9001197
("chore: remove unused terraform/ directory"), whose message confirms this was
deliberate and discussed with the repo owner ("Never applied... no intention of
using terraform/Hetzner going forward"). The test guarded real safety-critical
invariants (Grafana's firewall port never opened to the public) for a module that
no longer exists, so it's pure dead code now -- removed rather than updated,
since there's nothing left to test. The miner's separate Terraform module
(packages/loopover-miner/terraform/) is untouched and still has its own test.

test/unit/selfhost-sentry-release.test.ts asserted scripts/deploy-selfhost-prebuilt.sh
still defaults SENTRY_RELEASE to the pre-rename "gittensory-selfhost@..." prefix; the
script itself has already moved to "loopover-selfhost@...". Every other assertion in
this test (40+, covering the release workflow's Docker image naming, Sentry API calls,
and version-tag handling) was already correct and unaffected -- only this one stale
expected value needed updating to match reality.

Also regenerates scripts/branding-drift-baseline.json: unrelated to this change, but
picked up while re-verifying against a moving main -- a separate, concurrent rebrand
PR removed a "gittensory" comment mention in packages/loopover-mcp/bin/loopover-mcp.js
without regenerating the baseline, so the regression-guard test in
check-branding-drift-script.test.ts was failing on main itself.

Confirmed via git blame/content inspection that both original failures were unrelated
to any of this session's other PRs (verified real CI logs on #6900, which surfaced
these same 2 pre-existing failures despite never touching either file).
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 17, 2026
@JSONbored
JSONbored merged commit e118f6e into main Jul 17, 2026
14 checks passed
@JSONbored
JSONbored deleted the worktree-terraform-sentry-drift-cleanup branch July 17, 2026 11:38
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (99aeead) to head (3f7388f).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6902       +/-   ##
===========================================
+ Coverage   82.29%   93.70%   +11.40%     
===========================================
  Files         685      685               
  Lines       68284    68284               
  Branches    18715    18715               
===========================================
+ Hits        56195    63985     +7790     
+ Misses       9613     3302     -6311     
+ Partials     2476      997     -1479     
Flag Coverage Δ
shard-1 43.68% <ø> (?)
shard-2 36.79% <ø> (-0.01%) ⬇️
shard-3 32.66% <ø> (+<0.01%) ⬆️
shard-4 34.76% <ø> (?)
shard-5 31.17% <ø> (-0.01%) ⬇️
shard-6 45.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 204 files with indirect coverage changes

jeffrey701 pushed a commit to jeffrey701/gittensory that referenced this pull request Jul 17, 2026
Sweeps the rest of test/ for lingering pre-rename "gittensory" text that
PR JSONbored#6900 didn't already cover -- arbitrary example values, prose comments,
and non-functional identifiers with no behavioral dependency on the real
GITHUB_APP_SLUG or LOOPOVER_REVIEW_REPOS defaults. Purely 1:1 string swaps,
no logic changes.

Verified via three full unsharded npm run test:coverage passes. The first
(before rebasing onto JSONbored#6900/JSONbored#6902) was green on a stale base. After
reconciling onto the new origin/main, the second surfaced 3 files
(rag-index.test.ts, reputation-wiring.test.ts, ci-completion-fork-resume.test.ts)
where the renamed repo identity happened to be the SAME value load-bearing
against LOOPOVER_REVIEW_REPOS's still-current "JSONbored/gittensory,acme/widgets"
allowlist default -- reverted those three back to "gittensory" to keep the
allowlist match, matching the same reasoning JSONbored#6900 already applied to
GITHUB_APP_SLUG-dependent fixtures. The third run confirmed clean: 949 files,
18084 tests, 0 failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant