Skip to content

fix(gate): thread slop risk into check run - #721

Merged
JSONbored merged 2 commits into
mainfrom
codex/fix-slop-gate-blocker-in-github-check-run
Jun 14, 2026
Merged

fix(gate): thread slop risk into check run#721
JSONbored merged 2 commits into
mainfrom
codex/fix-slop-gate-blocker-in-github-check-run

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The computed slopRisk (from changed files + PR description) was used for the local gate evaluation but not passed into the policy used to publish the GitHub Gate check run, which could cause an opted-in slop: block rule to be ignored when finalizing the check run.

Description

  • Build a single gatePolicy that includes the live slopRisk and reuse it for both the in-memory evaluateGateCheck and the createOrUpdateGateCheckRun call to ensure the check run evaluation sees the same slop data; change made in src/queue/processors.ts.

Testing

  • Ran the targeted unit tests with npx vitest run test/unit/gate-check-policy.test.ts, which completed successfully (19 tests passed).
  • Ran npm run typecheck (tsc --noEmit) which completed with no type errors.

Codex Task

@ghost

ghost commented Jun 14, 2026

Copy link
Copy Markdown

Important

Gittensory found maintainer review notes

Scoped related-work signals were found for this PR. They are advisory unless the gate reports a blocker.

Readiness score: 70/100

Signal Result Evidence Action
Linked issue ⚠️ Missing No linked issue or no-issue rationale found. Explain no-issue PR.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden. Review top overlaps.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels. Add scope summary.
Validation evidence ✅ 25/25 PR body includes validation/test evidence. No action.
Open PR queue ⚠️ 5/10 9 open PR(s), 6 likely reviewable, 3 unlinked. Expect slower review.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 61 PR(s), 315 issue(s). No action.
Gate result ✅ Passing No configured blocker found. No action.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 61 PR(s), 315 issue(s).
  • Related work: Titles/paths share 8 meaningful terms. (PR #635, PR #637)
  • Related work: Titles/paths share 7 meaningful terms. (PR #637, PR #649)
  • Related work: Titles/paths share 7 meaningful terms. (PR #637, PR #650)
Maintainer notes
  • No linked issue detected: The planned PR does not reference a closing issue or explicit linked issue number.
  • Possible duplicate or overlapping work: 3 related open work cluster(s) were detected.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Expect slower review.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
  • Re-run Gittensory review

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 14, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@ghost

ghost commented Jun 14, 2026

Copy link
Copy Markdown

gittensory · advisory review

Reviewed 1 changed file(s) — two independent AI reviewers.

Suggested action:Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The PR fixes a bug where the gate check run was created without the slopRisk parameter by extracting the gate policy into a variable and using it consistently for both evaluation and check run creation. The change is small, clear, and does not introduce new public-facing content or security concerns.

Suggestions

  • Consider adding a unit test that verifies the gate check run receives the same policy (including slopRisk) as used for evaluation, to guard against regressions.

Worth double-checking

  • If gateCheckPolicy has side effects, calling it once vs twice could change behavior; however, this is unlikely.
  • Ensure existing tests that mock gate check behavior still pass with the new variable usage.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The PR fixes a bug in gate check run creation by ensuring the slopRisk parameter is consistently used in both gate evaluation and check run creation. Previously, the gate evaluation included slopRisk but the check run creation omitted it, causing inconsistency. The change extracts gateCheckPolicy into a constant for reuse, which is a safe refactor that resolves the discrepancy.

Worth double-checking

  • Verify that createOrUpdateGateCheckRun expects four arguments (settings, readiness.total, confirmedContributor, slopRisk) to match the gateCheckPolicy signature.
  • Ensure slopRisk is defined and non-null in all code paths where gateEnabled is true.

@ghost ghost added the gittensory-review label Jun 14, 2026
@dosubot dosubot Bot added the size:XS label Jun 14, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 0b4eb52 Commit Preview URL

Branch Preview URL
Jun 14 2026, 02:31 PM

@JSONbored
JSONbored merged commit 310810d into main Jun 14, 2026
11 checks passed
@JSONbored
JSONbored deleted the codex/fix-slop-gate-blocker-in-github-check-run branch June 14, 2026 14:32
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant