fix(miner-ui): register chat-action vite plugins for the preview server too - #7293
Conversation
…er too vite-chat-governor-actions.ts and vite-chat-discover-attempt-actions.ts implemented only configureServer, but the documented persistent-service path (README + systemd/loopover-miner-ui.service.example) runs npm run build && npm run preview, and vite preview fires only configurePreviewServer. So the governor pause/resume and discover/attempt chat actions were silently unregistered in production, unlike every sibling vite-*-api.ts plugin. Register on both hooks via a shared helper, mirroring the siblings, and add a parity test. Closes JSONbored#7228
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-19 13:14:42 UTC
Review summary Nits — 5 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (Linked issue overlaps another open PR; duplicate of open PR #7295). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Closes #7228
Summary
apps/loopover-miner-ui/vite-chat-governor-actions.ts(chatGovernorActionsPlugin) andvite-chat-discover-attempt-actions.ts(chatDiscoverAttemptActionsPlugin) implemented onlyconfigureServer().apps/loopover-miner-ui/README.md's "Running as a persistent service" +systemd/loopover-miner-ui.service.example) runsnpm run build && npm run preview, andvite previewfires onlyconfigurePreviewServer, neverconfigureServer. So the governor pause/resume and discover/attempt chat actions were silently unregistered undervite previewin production — unlike every siblingvite-*-api.tsplugin, all of which register for both hooks.configureServerandconfigurePreviewServervia a sharedregisterhelper in each plugin (the exact both-hooks shape the sibling plugins already use). No new/api/*route is added; only the existing plugin hook is wired for preview. Adds a parity test asserting both plugins now implement both hooks.Scope
type(scope): short summaryConventional Commit format.configurePreviewServergap called out in the issue. No othervite-*-api.tsfile and no new route are touched.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #7228(bare, above).Validation
git diff --check— clean.npm run ui:typecheck(@loopover/ui-minertsc --noEmit) — 0 errors.npm run ui:test(@loopover/ui-minervitest run --coverage) — 322 tests pass, coverage thresholds met; the newvite-chat-action-plugins.test.ts(2 tests) passes.npm --workspace @loopover/ui-miner run build(vite build) — built successfully.If any required check was skipped, explain why:
test:coverage,test:workers,build:mcp/test:mcp-pack,ui:openapi:check, engine/miner suites,npm audit) are not applicable: this PR touches onlyapps/loopover-miner-ui/**(two Vite plugin config files + one test) — nosrc/**, no MCP/API/OpenAPI surface, no engine, and no dependency changes.apps/**is outside the Codecovcodecov/patchscope; the miner-ui workspace's own vitest coverage thresholds (verified above) are the relevant signal.Safety
/api/*behindauthPlugin()invite.config.ts, unchanged.UI Evidencesection — N/A: no visible/visual change. The fix only makes existing chat actions register when the app is served viavite preview; there is no new or altered rendered surface to screenshot.UI Evidence
Not applicable — no visible/visual change. This PR wires two Vite dev/preview-server plugins to register on the preview hook in addition to the dev hook; nothing rendered changes.
Notes
vite devfiresconfigureServer,vite previewfiresconfigurePreviewServer), so registering on both is safe — only one runs per process.