fix(queue): record gate_check_run in failedOutputs on double failure

[joaovictor91123]

Summary

• When a gate_check_run primary publish and its createOrUpdateErroredGateCheckRun fallback both fail (or no pending id exists to fall back on), push a gate_check_run entry onto failedOutputs, matching check_run / comment / label.
• Gate-only repos now fire pr_public_surface_failed, capturePostHogReviewFailure, and RetryablePublicSurfacePublishFailedError (when transient) instead of silently leaving both output lists empty.
• Adds queue coverage for the permission_missing double-failure path and the transient 5xx primary+fallback path.

Closes #8686

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) - a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ?99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Local Node is v24; repo engines pin Node 22 - new coverage lives in test/unit/queue-4.test.ts and will run under CI. No UI/MCP-pack surface in this change.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A - no visible UI changes.

Notes

• Fallback publish behavior is unchanged; only the final double-failure recording into failedOutputs is added so finishPublicSurfacePublication can escalate.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Caution

🛑 LoopOver review result - fixes required

_{Review updated: 2026-07-26 01:36:56 UTC}

2 files · 1 AI reviewer · no blockers · CI failing · blocked

🛑 Suggested Action - Fix Blockers

Review summary
This PR adds a failedOutputs entry for gate_check_run when both the primary publish and the createOrUpdateErroredGateCheckRun fallback fail, mirroring the existing check_run/comment/label contract so gate-only repos correctly trigger pr_public_surface_failed, PostHog escalation, and transient retry instead of silently leaving both output lists empty. Two new tests exercise the permission_missing double-failure path and the transient 5xx primary+fallback path, both asserting the failedOutputs entry and downstream escalation behavior. The change is narrow, closes a linked issue (#8686), and correctly gates on `!gateFinalized` in both the check-run creation catch block and the outer catch block.

Nits — 4 non-blocking

• The two `!gateFinalized` blocks (src/queue/processors.ts, both hunks) push nearly identical failedOutputs entries with only the error/transient values differing — consider extracting a small helper if a third call site is ever added, though two occurrences is fine as-is.
• The FAILED validate/validate-tests checks are undetailed; per BASE BRANCH STATUS this branch is 1 commit behind the default branch, which is a plausible cause worth checking via a rebase before assuming a defect in this diff.
• Confirm whether `validate`/`validate-tests` failures are pre-existing on the default branch by rebasing this branch and re-running CI.
• If a third failedOutputs push site is added later (e.g. another fallback type), consider factoring the push shape into a small helper to keep the `output`/`error`/`transient` contract consistent.

CI checks failing

• validate
• validate-tests

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8686
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 161 registered-repo PR(s), 73 merged, 5 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	joaovictor91123; Gittensor profile; 161 PR(s), 5 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff adds failedOutputs.push({ output: "gate_check_run", ... }) both in the permission_missing branch and the outer catch when the fallback also fails, mirroring the check_run/comment/label pattern, and includes two new tests exercising the permission_missing and transient double-failure paths that assert failedOutputs, the pr_public_surface_failed audit event, capturePostHogReviewFailure, and

Review context

• Author: joaovictor91123
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, MDX, TypeScript, C++, CSS, Rust
• Official Gittensor activity: 161 PR(s), 5 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.