Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/loopover-engine/src/governor/chokepoint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ function denyResult(input: {
eventType: input.eventType,
repoFullName: input.repoFullName,
actionClass: input.actionClass,
decision: input.stage === "kill_switch" ? "paused" : input.eventType === "throttled" ? "throttle" : "deny",
// Key off eventType, not stage: budget-cap termination fires stage "budget_cap" with
// eventType "kill_switch" and must still ledger as "paused" (#8864).
decision: input.eventType === "kill_switch" ? "paused" : input.eventType === "throttled" ? "throttle" : "deny",
reason: input.reason,
payload: { stage: input.stage, ...input.extraPayload },
},
Expand Down
2 changes: 2 additions & 0 deletions packages/loopover-engine/test/chokepoint.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ test("budget cap: the termination ceiling denies with a kill_switch eventType (h
);
assert.equal(decision.stage, "budget_cap");
assert.equal(decision.ledgerEvent.eventType, "kill_switch");
// eventType (not stage) drives ledger decision — termination is a kill_switch, so "paused" (#8864)
assert.equal(decision.ledgerEvent.decision, "paused");
});

test("non-convergence: a stuck item denies before reputation/self-plagiarism run", () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { describe, expect, it } from "vitest";

import {
evaluateGovernorChokepoint,
type GovernorChokepointInput,
} from "../../packages/loopover-engine/src/governor/chokepoint";

function baseInput(overrides: Partial<GovernorChokepointInput> = {}): GovernorChokepointInput {
return {
actionClass: "open_pr",
repoFullName: "acme/widgets",
nowMs: 10_000,
wouldBeAction: { action: "open_pr", title: "Fix bug" },
killSwitchGlobal: false,
killSwitchRepoPaused: false,
liveModeGlobalOptIn: true,
liveModeRepoOptIn: "live",
rateLimitBuckets: { global: {}, perRepo: {} },
rateLimitBackoffAttempts: {},
capUsage: { budgetSpent: 0, turnsTaken: 0, elapsedMs: 0 },
capLimits: { budget: 100, turns: 100, elapsedMs: 1_000_000 },
convergenceInput: { attempts: 0, consecutiveFailures: 0, reenqueues: 0, reachedDone: false },
...overrides,
};
}

describe("denyResult ledger decision keys off eventType (#8864)", () => {
it("budget-cap termination ceiling ledgers decision paused (kill_switch eventType, budget_cap stage)", () => {
const decision = evaluateGovernorChokepoint(
baseInput({
capUsage: { budgetSpent: 0, turnsTaken: 0, elapsedMs: 2_000_000 },
capLimits: { budget: 100, turns: 100, elapsedMs: 1_000_000 },
}),
);
expect(decision.stage).toBe("budget_cap");
expect(decision.ledgerEvent.eventType).toBe("kill_switch");
expect(decision.ledgerEvent.decision).toBe("paused");
});

it("top-level kill_switch stage still ledgers paused", () => {
const decision = evaluateGovernorChokepoint(baseInput({ killSwitchGlobal: true }));
expect(decision.stage).toBe("kill_switch");
expect(decision.ledgerEvent.eventType).toBe("kill_switch");
expect(decision.ledgerEvent.decision).toBe("paused");
});

it("budget-cap soft deny (non-termination) still ledgers deny", () => {
const decision = evaluateGovernorChokepoint(
baseInput({
capUsage: { budgetSpent: 100, turnsTaken: 0, elapsedMs: 0 },
capLimits: { budget: 100, turns: 100, elapsedMs: 1_000_000 },
}),
);
expect(decision.stage).toBe("budget_cap");
expect(decision.ledgerEvent.eventType).toBe("denied");
expect(decision.ledgerEvent.decision).toBe("deny");
});
});
Loading