fix(engine): classify 'ci' change-kind only by real CI path segments, not any .yml/.yaml (#8873) - #8983
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
… not any .yml/.yaml objective-anchor.ts's kindsFromPath tagged any YAML file as 'ci' via a bare `.yml`/`.yaml` extension fallback, so a root `.loopover.yml` or `docs/mkdocs.yml` diluted the 'ci' change-kind dimension scoreObjectiveAnchor relies on. Drop the extension fallback -- 'ci' is now classified only via a real CI path segment (CI_SEGMENTS), the same path-segment discipline every other change-kind uses. Tests: a config YAML at the repo root and docs/mkdocs.yml no longer produce 'ci'; a YAML under a real CI path segment (.github/workflows/ci.yml) still does.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8983 +/- ##
==========================================
- Coverage 93.87% 93.87% -0.01%
==========================================
Files 807 807
Lines 80448 80448
Branches 24391 24390 -1
==========================================
- Hits 75522 75520 -2
+ Misses 3561 3560 -1
- Partials 1365 1368 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 15:18:44 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Problem
Closes #8873.
packages/loopover-engine/src/objective-anchor.ts'skindsFromPathclassifiedciviaCI_SEGMENTS.has(segment) || filename.endsWith('.yml') || filename.endsWith('.yaml'). The bare-extension fallback tagged any YAML file — root.loopover.yml,docs/mkdocs.yml— asci, diluting thecichange-kind dimensionscoreObjectiveAnchorrelies on.Fix
Drop the extension fallback.
ciis classified only via a real CI path segment (CI_SEGMENTS), the same path-segment discipline every other change-kind uses.Tests
.loopover.ymlanddocs/mkdocs.ymlno longer produceci;.github/workflows/ci.ymlstill does. Reverting fails the negative assertions.git diff --checkclean.(Re-opened after the prior run's
validate-testshit a transient CI infra flake —npm ciretry exhaustion + missing MCP/miner build binaries, unrelated to this engine-only change; tests pass locally.)