fix(review): render fix-handoff locations with a length-based code-span delimiter - #9347
fix(review): render fix-handoff locations with a length-based code-span delimiter#9347bitfathers94 wants to merge 1 commit into
Conversation
…an delimiter markdownPathCodeText backslash-escaped backticks, but Markdown code spans are delimited by a run of backticks and do not honor a preceding backslash, so a finding path containing a literal backtick corrupted the rendered fix-handoff block. Compute a delimiter longer than any backtick run in the value and wrap the whole location in it — mirroring markdownPathCode in unified-comment-bridge.ts — and let both call sites consume that span directly instead of re-wrapping in a fixed single backtick.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 13:46:09 UTC
Review summary Nits — 4 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
fix(review): render fix-handoff locations with a length-based code-span delimiter
markdownPathCodeText backslash-escaped backticks, but Markdown code spans
are delimited by a run of backticks and do not honor a preceding backslash,
so a finding path containing a literal backtick corrupted the rendered
fix-handoff block. Compute a delimiter longer than any backtick run in the
value and wrap the whole location in it — mirroring markdownPathCode in
unified-comment-bridge.ts — and let both call sites consume that span
directly instead of re-wrapping in a fixed single backtick.
Closes #9289
Validation
Verified locally on this branch before opening:
npm run typechecknpx turbo run build:tsc build:verifynpm run test:coverage— patch coverage 100.0% of changed lines