feat(signals): slop signal — duplicate-cluster membership (#563)

[oktofeesh1]

Closes #563 (epic #530 deterministic slop signals).

What

Adds the duplicate-cluster-membership slop signal: it fires when a PR sits in a high-risk collision cluster that holds 2+ open pull requests — i.e. genuine overlapping/duplicate work.

How (precise, zero added gate cost)

• Reuses buildCollisionReport — specifically the collision report the gate already builds for queue health, passed into the slop input. No extra DB load or O(n²) compute on the hot gate path.
• False-positive-averse (this score can gate): the 2+-pull-request bar deliberately excludes a healthy issue↔its-own-linking-PR pair, which buildCollisionReport also marks high-risk (the feat(api): maintainer quality-dashboard service + endpoint #557 lesson). Only genuine duplicate-PR overlap trips it.
• Weighted 15 (a secondary signal, like empty-description); static, public-safe detail text. Inert on the local lint surfaces (they have no repo collision context).

Tests

test/unit/slop.test.ts: fires for a high-risk 2-PR cluster containing the PR; no fire for missing context, an issue+PR pair, a non-high-risk cluster, or a cluster the PR isn't in. Full npm run test:coverage green (branches 97.03%); new lines fully covered (slop.ts + the 2 reused-context lines in the gate); output stays public-safe.

Files: src/signals/slop.ts (signal), src/queue/processors.ts (2 lines: pass the already-built collisions + PR number), slop test.

🤖 Generated with Claude Code

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#942 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[ghost]

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

⛔ Maintainer review — Blockers found

Reviewed 3 changed file(s) — two independent AI reviewers, synthesized.

ℹ️ This PR conflicts with main and can't be merged as-is. Conflicting file(s): src/queue/processors.ts, src/signals/slop.ts, test/unit/slop.test.ts. Resolve the conflict(s) and open a fresh PR.

Merge readiness: ❌ CI is red — approval withheld until it's green. Failing: see the checks tab.

Summary

The new duplicate‑cluster slop signal is correctly integrated into the slop assessment and the queue processor, and the tests cover its behavior. However, the function buildDuplicateClusterFinding is not exported, yet the test suite imports it, causing a TypeScript compile error. This is a concrete blocker.

🛑 Hard blockers — must fix before merge

• buildDuplicateClusterFinding is defined without an export, but the test file imports it, leading to a build failure.

💡 Nits — non-blocking, optional

• Add the export keyword to the buildDuplicateClusterFinding function definition so it can be imported by the test suite.
• Verify that the CollisionReport type is exported from ./engine (if not, export it there).
• Consider adding a comment explaining the purpose of the collisions and pullNumber fields in SlopAssessmentInput.
• Ensure that the collisionReport function is well-documented and its usage is clear in the tests.

This repo uses one-shot review: a rejected PR is closed, not iterated in place. Address the above and open a new focused PR.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[superagent-security]

⚠️ Contributor trust inconclusive. Click here for more info: Superagent Dashboard

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (9cbdc6a) to head (a54cbb3).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         110      110           
  Lines       14997    15008   +11     
  Branches     5419     5424    +5     
=======================================
+ Hits        14491    14502   +11     
  Misses        104      104           
  Partials      402      402           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.