Placement compatibility expansion#12
Draft
JSYoo5B wants to merge 11 commits into
Draft
Conversation
JSYoo5B
commented
Jul 2, 2026
| idGen idgen.Generator | ||
| } | ||
|
|
||
| type Repositories struct { |
Owner
Author
There was a problem hiding this comment.
Placement has enough repositories that grouping them into a struct improves service construction readability. This is the same explicit dependency approach as compute, just packaged for a wider surface.
JSYoo5B
commented
Jul 2, 2026
| return candidates | ||
| } | ||
|
|
||
| for _, provider := range s.resourceProviderRepository.List() { |
Owner
Author
There was a problem hiding this comment.
Allocation candidates are intentionally computed from current providers, inventories, and usages rather than stored as their own resource. This is the key semantic endpoint in the Placement slice.
JSYoo5B
commented
Jul 2, 2026
| return resources | ||
| } | ||
|
|
||
| func capacity(inventory Inventory, used int) int { |
Owner
Author
There was a problem hiding this comment.
Capacity follows the simple Placement formula used by this MVP: total minus reserved, multiplied by allocation ratio, then reduced by usage. Nested providers or sharing providers would need a more advanced model later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Review Points
Verification