Store layer consolidation#6
Draft
JSYoo5B wants to merge 7 commits into
Draft
Conversation
JSYoo5B
commented
Jul 2, 2026
| imageService := appimage.NewService() | ||
| networkService := appnetwork.NewService() | ||
| volumeService := appvolume.NewService() | ||
| computeService := appcompute.NewServiceWithRuntime( |
Owner
Author
There was a problem hiding this comment.
This router now acts as the composition root for default in-memory services. The important dependency direction is API -> app interfaces plus store implementations supplied here, not app -> store concrete types.
JSYoo5B
commented
Jul 2, 2026
| clock.Wall(), | ||
| idgen.Random(), | ||
| ) | ||
| networkService := appnetwork.NewServiceWithRepositories( |
Owner
Author
There was a problem hiding this comment.
Network has multiple repositories earlier than the other services because networks, subnets, and ports already have independent state. This is the representative wiring pattern for services that grow more than one resource store.
JSYoo5B
commented
Jul 2, 2026
| @@ -45,6 +45,31 @@ func (h Handler) getVolume(w http.ResponseWriter, r *http.Request) { | |||
| }) | |||
| } | |||
Owner
Author
There was a problem hiding this comment.
Update endpoints follow the existing handler convention rather than introducing a generic patch layer. That keeps this slice scoped to the compatibility calls currently needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Review Points
Verification