perf T4-W1: `libby init --help` runs the full setup wizard (measured 2442 ms of network probes + authenticate) instead of printing help

[JavaGT]

Measured (median of 9 spawns, this machine, 2026-09-11)

libby init --help — 2442 ms, exit 0. The init branch (bin/libby.mjs:232-235) ignores all args and always calls runInit(), which non-interactively:

1. network-probes detectInsecureTLS (src/init.mjs:64-75)
2. resolves the saved library key over the network (src/init.mjs:93)
3. runs authenticate (src/init.mjs:119) — cached-session verify() = GET /chip/sync
4. reaches saveConfig (src/init.mjs:134)

This run's probes + authenticate did execute (that is the 2.4 s); the owner's config.json/session.json were verified untouched by mtime afterward — but a wizard run that completes its save would rewrite the user config as a side effect of asking for help.

Fix shape

In the init branch, handle --help/-h before runInit(): print init usage, exit 0. Everything else about runInit is out of scope.

Out-of-scope observation for the owner (no change proposed in this ticket): non-TTY libby init runs the whole wizard silently on saved defaults — stdin-closed prompts resolve instantly, so a scripted/accidental invocation can network-probe, re-authenticate, and rewrite config with nobody watching.

Acceptance

1. libby init --help prints usage and exits 0 with spawn median within noise of libby help; zero network (hermetic: run with XDG_CONFIG_HOME pointed at an empty temp dir so even a regression cannot touch the real config).
2. Spawn pin in test/cli-lazy.test.mjs for the above.
3. libby init without flags still starts the wizard (no behavior change).
4. node --test green; changes confined to bin/libby.mjs + test/cli-lazy.test.mjs.

Related: #10 (usage-error paths pay session bootstrap), #12 (cached-session verify cost).

[JavaGT]

Claimed — implementing now, will land on main with evidence.

[JavaGT]

Fixed on main: 6e01dad (report a433f86, perf/lanes/T4-W1-report.md).

Init branch now handles --help/-h before runInit(): prints a short init usage and exits 0. libby init with no flags still runs the wizard unchanged.

Measured (median of 9, interleaved base-vs-after, Apple M4 / Node 26.7.0): libby init --help 2512.4 ms → 25.5 ms (libby help reference 50.4/25.2 ms); zero network on the help path.

Pin in test/cli-lazy.test.mjs: init --help and init -h with XDG_CONFIG_HOME at an empty temp dir → exit 0, usage on stdout, no "Checking connection"/"Saved". Pin FAILS on base 23bd9b7 (wizard ran, 1631 ms) and passes after. Owner config/session verified byte-identical across measurement runs. Focused 6 pass / 0 fail; full suite 89 pass / 0 fail.

[JavaGT]

review round 1 addressed: c174a38

[JavaGT]

review round 2 addressed: 2ab7719

[JavaGT]

Landed + hostile-review APPROVED (round 3). Commits: 6e01dad (init --help/-h usage before runInit), c174a38 + 2ab7719 (review-round test hardening), a433f86 (report: perf/lanes/T4-W1-report.md).

Measured: libby init --help 2442 ms → 25.2 ms (at the libby help floor), exit 0, zero network — the wizard (network probes + authenticate + config save) no longer runs as a side effect of asking for help. Plain libby init unchanged; runInit is not even imported on the help path.

Test: hermetic pin with XDG_CONFIG_HOME on an empty temp dir + network-denial preload, so a regression fails deterministically with zero network. The non-TTY wizard observation from the ticket body remains noted for the owner (out of scope here, no change proposed). Review trail: rounds 1-2 MINOR (shared test harness findings, fixed under #10) → round 3 APPROVED (GPT 5.6 Luna via opencode2). Full suite 91/0.