Refactor caches#9
Merged
Merged
Conversation
Create an object that can be added to a list by reference, but preserve dict() functionality.
Preserve docstrings of cached functions Use str() to create hashable keys Update docstring / PEP8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't fix a real bug, but I ran into this when I encountered a syntax error in a test. Instead of the test throwing an exception, I got a
TypeError(which turned out to be from thecheckpy.caches.cachememoization decorator). Subsequently while trying to debug inipython, the function signatures where hidden by the decorator. So it was hard to find out which function was throwing the exception.This PR solves both issues. Fixes #8.
Changes:
str()functools.wrapsto expose wrapped function__doc__,__name__etc._Cacheas minimal subclass ofdictI feel this code needs to explain why
sys.argvneeds to be a key. From the code I cannot understand, why sys.argv could have a side effect on a cached function, and both the issue (#7) and commit (a544084) are very non-descript.