Fix Go local type scope in quick scanner - #204
Merged
Merged
Conversation
Only package-scope type declarations should become symbols, so local declarations cannot shorten function ranges or take ownership of calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Go local type declarations were indexed as package symbols, truncating their enclosing function ranges and assigning later calls to the local type.
After this PR:
Track Go lexical brace depth and add only package-scope type declarations as symbols. Regression tests cover function ranges, call ownership, and braces in comments and strings.
Type of change
Bug fix