Test valid Go import target resolution - #208
Merged
Merged
Conversation
Keep the resolver fixture aligned with Go module boundaries so this test cannot pass through a global symbol fallback alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The shared Go fixture placed helper.go beside main.go without a module declaration. The imported-function test could therefore pass through global symbol fallback without a resolved proj/helper import target.
After this PR:
The fixture declares the proj module and places helper in its own package directory. The resolver test now requires a non-null import target and checks that both the import target and helper.Greet call resolve to helper/helper.go. Walk and builder expectations follow the relocated fixture.
Type of change
Test