fix(resolver): block invalid import call fallback - #26
Draft
JohnXu22786 wants to merge 2 commits into
Draft
JohnXu22786 wants to merge 2 commits into
JohnXu22786 wants to merge 2 commits into
Conversation
Keep unresolved Python from-import bindings from falling through to a globally unique symbol, and reject relative imports that traverse beyond the package depth.
Raw Python from-import entries include alias and wildcard syntax, so compare bound names before allowing an unresolved import to use the global fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
Over-deep Python relative imports could remain unresolved while calls through imported names fell through to unrelated globally unique symbols. Raw aliases and wildcard imports could bypass the guard.
After this PR:
Unresolved Python
frombindings stop before global-name fallback, includingasaliases and*imports. Relative imports beyond package depth are rejected in module and imported-file resolution. Focused regression coverage covers the direct, aliased, and wildcard forms with one uniquefoosymbol.Type of change
Bug fix