Disable testing properly - #214
Merged
Merged
Conversation
This was referenced Apr 12, 2024
Collaborator
|
Looks good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasted some time trying to understand what
test/runtests.jlactually does (after recovering a functioning Project.toml) and why CI.yml is disabled (commented out).Here's the reason, from a comment in
/test/runtests.jladded in this PR:After this PR, you can now run
Pkg.test("DataScienceTutorials")without weird output, but it executes no actual testing and prints a warning explaining the current situation.Will open PR shortly to flag the lack of automated testing.
This PR also adds
/Manifest.tomlto.gitignoreand removes this top level Manifest.toml, which is not attached to any tutorial, but used only locally for developers (e.g., forinclude("deploy.jl")).