Fix DBInterface transaction values and NULL binding - #239
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 69.82% 69.89% +0.07%
==========================================
Files 10 10
Lines 1183 1186 +3
==========================================
+ Hits 826 829 +3
Misses 357 357 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nothingas SQLNULL, matching the existingmissingbehaviorRoot cause
DBInterface.transactiondiscarded the closure result and returned the C API commit result. The prepared-statement binder had a null path only forMissing, soNothingfell through to aMethodError.Scope
This addresses behaviors 2 and 3 from #238. The connection-level
DBInterface.execute(conn, sql, params)form remains unsupported. Implementing it safely requires a statement-lifetime design because query cursors can outlive the call.Validation
mysql:8: 200 testsnothing, a concrete value, andmissingin sequencegit diff --checkRefs #238
Co-authored by Codex