fix: backwards-compatible ctype data decoding - #703
Merged
Merged
Conversation
rflechtner
marked this pull request as ready for review
January 25, 2023 19:35
ntn-x2
approved these changes
Jan 26, 2023
ntn-x2
left a comment
Contributor
There was a problem hiding this comment.
LGTM! The only thing that's not 100% clear is why we don't use the storage version number, that we decided to be 2 for the valid storage structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure the sdk still decodes CType records from before the chain upgrade to 0.9.0 / 0.8.5.
Adjust tests so that CType fetching is skipped where not available.
How to test:
We should no longer see the
Invalid empty address passederrors in integration tests againstlatest(e.g., https://github.com/KILTprotocol/sdk-js/actions/runs/4003744234/jobs/6872161008).Fetching CType data will still fail withCannot fetch CType definitions on a chain that does not store the createdAt block.Checklist: