Skip to content

Step by step walkthrough - #314

Merged
evanroyrees merged 1 commit into
KwanLab:devfrom
kaw97:step_by_step_walkthrough
Apr 21, 2023
Merged

evanroyrees merged 1 commit into
KwanLab:devfrom
kaw97:step_by_step_walkthrough

Conversation

@kaw97

@kaw97 kaw97 commented Mar 23, 2023 •

Copy link
Copy Markdown
Collaborator

closed old PR and opened new one to merge to dev, issue #304

@kaw97
kaw97 requested a review from chasemc March 23, 2023 21:46
@chasemc

chasemc commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

See #315 (comment)

@Sidduppal
Sidduppal self-requested a review April 21, 2023 15:23
explanation is now in the same order as the commands are input and deprecated --domain has been replaced with rank-filter-name
@kaw97
kaw97 force-pushed the step_by_step_walkthrough branch from 4fc34b1 to 3da3f63 Compare April 21, 2023 15:40

@Sidduppal Sidduppal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@WiscEvan and @chasemc
@kaw97 ran git rebase so that it's appropriately checked out from dev instead of main (which was done before). I think it looks good to me, can you guys confirm and merge?

@evanroyrees evanroyrees linked an issue Apr 21, 2023 that may be closed by this pull request
@evanroyrees
evanroyrees merged commit 32f44d0 into KwanLab:dev Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation needs edit

4 participants