fix(tbc): correct rep caps, phase map, attunements - #31
Merged
Conversation
Cross-checked every factual table against Wowhead TBC Classic, warcraft.wiki.gg, Icy Veins, and the 2026 anniversary-realm phase schedule (six research passes). Most corrections fix data errors carried over from the source spreadsheet; the non-obvious finding is the heroic key requirement: the announced Honored threshold never shipped at the February launch, so Revered is still required on mains as of p2 — the guide keeps Revered and now says why. Diff is data-only; index.html regenerated in sync via --check.
Contributor
Author
|
Verified: all changed facts trace to Wowhead TBC Classic, warcraft.wiki.gg, Icy Veins, and 2026 anniversary phase coverage. The heroic-key requirement and Shadow Labyrinth normal-mode cap were cross-checked against two sources before landing. Build: index.html regenerated from the generator; CI --check green. Render: new revered/friendly badges, phase legend, keys rules box, and difficulty tiers checked on preview. Leak grep clean. Merging (squash). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validates the TBC dungeon-rep guide — previously sourced from a
single spreadsheet — against Wowhead TBC Classic, warcraft.wiki.gg,
Icy Veins, and the 2026 anniversary phase schedule (six research
passes). Fixes every table entry that didn't hold up and adds
verified enrichments.
Corrections:
Exalted; the factions lead now notes heroics pay through Exalted.
Friendly, not Honored.
Sunwell / Magisters' Terrace / Shattered Sun p4 (was p5),
Zul'Aman p3.5 (was p4); phase legend added (p2 live May 14, 2026).
the freed-slave rep cutoff; Underbog tip drops Unidentified Plant
Parts (they cap at Honored) and adds Coilfang Armaments; Consortium
card gains its missing Revered/Exalted paths (Zaxxis Insignia,
Obsidian Warbeads, Ethereum Prison Keys).
Enrichments:
p2 (the announced Honored change never shipped at the February
launch — verified against launch-week forum reports), attunements
are account-wide, alts can use a Communal Heroic Key at Friendly.
signets, the four trials, Al'ar via Ruse of the Ashtongue); Shadow
Lab key located at Ikiss's chest; golden rule explains turn-in
banking; Black Morass noted as paying twice (heroic key + Hyjal
attune).
Why
The guide was sourced from a single spreadsheet. Cross-checking
found real errors (the Shadow Labyrinth cap, the Sha'tar spillover
ceiling, the phase numbering, which still followed 2021's
five-phase plan) plus several places where the right answer needed
context the spreadsheet couldn't carry — most notably heroic keys,
where the announced Honored change never shipped and Revered still
gates mains as of p2.
Test plan
python3 tbc/build_tbc_guide.py --checkpasses (index.htmlregenerated in sync).
legend, keys rules box, and difficulty tiers all render correctly.