Read only up to MaxSize for VMDK header#2
Merged
Olof-Lagerkvist merged 1 commit intoJun 28, 2023
Merged
Conversation
…reamReader.ReadLine() would block until it encountered an EOL character. In my case, a faulty NFS client caused all bytes to be read as 0. This caused the program to fill up the entire memory while reading a large VMDK. This implementation reads only the bytes up to MaxSize. It also: - Uses UTF-8 encoding, instead of ASCII - Performs case insensitive searches. This is based upon the "standard" defined here: https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc
Member
|
Thanks a lot for this! Just made some minor changes, try/finally around the ArrayPool Rent/Return to avoid memory leak in case of exceptions and also changed Encoding.UTF8.GetString to only use actual number of read bytes in the array. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While handling an untrusted stream, in the old implementation, the StreamReader.ReadLine() would block until it encountered an EOL character.
In my case, a faulty NFS client caused all bytes to be read as 0. This caused the program to fill up the entire memory while reading a large VMDK.
This implementation reads only the bytes up to MaxSize. It also:
https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc