Fix LzxDecoder's handling of odd sized uncompressed blocks if that block is the final one#73
Merged
Olof-Lagerkvist merged 1 commit intoJul 14, 2026
Conversation
Olof-Lagerkvist
merged commit Jul 14, 2026
2c3b93b
into
LTRData:LTRData.DiscUtils-initial
3 checks passed
Member
|
Well spotted! Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of LzxDecoder correctly reads the padding byte to realign the stream to 16 bits in case the uncompressed block is of an odd size.
DiscUtils/Library/DiscUtils.Core/Compression/LzxDecoder.cs
Line 237 in aada925
However, if that's the last block there is no next block to align it for and even Microsoft's own tool doesn't append that padding byte, causing the read attempt below it to fail for valid blocks.
DiscUtils/Library/DiscUtils.Core/Compression/LzxDecoder.cs
Lines 239 to 242 in aada925
I couldn't find where it's documented but looking at wimlib's implementation, they only check for that padding byte in case the block wasn't the last one, matching that behaviour.
This PR adds the same fix to the DiscUtils' code which makes it correctly extract the files I encountered this issue with.