Better fix for reentrancy issue#7797
Open
labkey-adam wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We evaluate every query for mutating SQL, unless a specific deprecated feature flag is set. If not already cached, we need to query the feature flag property map. This can result in reentrancy and a stack overflow.
Previous fix eliminated most reentrancy cases, but detecting mutating SQL before checking the flag avoids checking the flag in the read case.
Also, designate
SimpleActionas read-only,ConfirmActionas read-only when using GET, and make the action checks more readable.Related Pull Requests