fix(storage): harden checkpoint crash recovery (fixes #1098) - #1107
Merged
Merged
Conversation
adsharma
force-pushed
the
fix-1098-checkpoint-recovery-hardening
branch
from
October 5, 2026 16:56
da6ffb3 to
55cba22
Compare
Three native-crash sites on the interrupted-checkpoint open path now fail with catchable exceptions so recovery discards the torn tail instead of segfaulting: - ValueVector::deSerialize rejects num_values above capacity - table insertion replay rejects empty/null vector state - shadow sidecar smaller than one page is rejected before the header read (covers the 0-byte .shadow fixture)
adsharma
force-pushed
the
fix-1098-checkpoint-recovery-hardening
branch
from
October 5, 2026 17:37
55cba22 to
170f02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates and fixes #1098 (SIGSEGV opening preserved interrupted-checkpoint journal).
Three native-crash sites now throw catchable exceptions so recovery discards the torn tail:
Validation: full release build passes; FrozenWALRecoveryTest green. Minimal local testing per policy — CI owns the rest.