fix: make secret-messages type-check at the project level - #339
Merged
Merged
Conversation
3 tasks
`check-solutions.sh "tsc"` runs a bare `npm run tsc` in every project, which for secret-messages compiles both steps against the project-level TSConfig. That has failed since the project was added in #82, but the all-projects branch only runs when a PR touches no `projects/**` files, so it went unnoticed. `answer.js` and `guesses.json` need `allowJs` and `resolveJsonModule`, which exist only in the step's own TSConfig -- the file the reader fills in, and which a project-level `tsc` never reads. Adds them to the project TSConfig, with `noEmit` to avoid TS5055 overwriting `answer.js`. `message.codePointAt(i)` is typed `number | undefined`, so it needs a non-null assertion under `strict`. Switches both steps to `charCodeAt`, which returns `number` and pairs more naturally with `fromCharCode`. That also drops the `!` from `01-encoded-outputs`, which was the only non-null assertion in the repository -- worth avoiding in a chapter 13 project regardless. Output is unchanged: the two differ only for characters above the BMP, and these messages are ASCII. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoshuaKGoldberg
force-pushed
the
fix-secret-messages-project-tsc
branch
from
September 22, 2026 13:17
476d444 to
7514b70
Compare
JoshuaKGoldberg
marked this pull request as ready for review
September 22, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
A project-level
tsccompiles both steps againstsecret-messages/tsconfig.jsonand never reads the step TSConfigs.allowJsandresolveJsonModuleto the project TSConfig, plusnoEmit— without itallowJshits TS5055 overwritinganswer.js.codePointAttocharCodeAt, which returnsnumberrather thannumber | undefinedand pairs more naturally withfromCharCode.