Build packages with GitHub Actions - #1
Open
guacforlife wants to merge 1 commit into
Open
Conversation
Adds a workflow that builds the roothide (iphoneos-arm64e) and rootless (iphoneos-arm64) packages on macOS runners, using the iOS SDK the runner already provides through Xcode, so both are downloadable without a local Theos setup. Both builds sign with codesign instead of ldid. ldid writes a signature that leaves the arm64e slice effectively unsigned, and current bootstraps refuse to load it. The verify step guards the two failure modes that produce a package which installs cleanly and then does nothing: a filter plist that is not world readable, and a dylib with no arm64e slice. ElleKit skips both without logging anything. Pushing a v* tag publishes the packages as a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow that builds both packages in CI, so people on iOS 17 can install the fix without setting up Theos locally. No source,
control, orMakefilechanges.What it builds
A macOS runner checks out both Theos forks, links the iOS SDK Xcode already provides on the runner, and builds twice from the same source:
iphoneos-arm64eiphoneos-arm64Both are uploaded as a
packagesartifact on every push and pull request. Pushing av*tag publishes them as a release.TARGETis overridden on the command line toiphone:clang:latest:17.0, so the build picks up whichever SDK the runner image ships while keeping the 17.0 deployment target the Makefile asks for.codesign rather than ldid
The builds pass
TARGET_CODESIGN=codesignwith ad-hoc flags. ldid writes a signature that leaves the arm64e slice effectively unsigned, and current bootstraps then refuse to load the dylib.Verify step
Two packaging mistakes produce a package that installs cleanly and then does nothing, because ElleKit skips the dylib without logging anything:
CI fails on either, so neither can reach a release.
Green run on the fork, including the published release: https://github.com/guacforlife/CranePKDServerFix/releases/tag/v0.0.1
Thanks for writing the fix.