Touchups - #61
Merged
Merged
Conversation
justinrubek
requested changes
May 16, 2021
justinrubek
left a comment
Contributor
There was a problem hiding this comment.
This looks pretty good. The navbar needs to be touched up though:
- The Levity logo and text don't navigate from the about page to the home page, but rather they currently stay on the current page
- Opening the about page currently opens in a new tab
This is how the main page's nav bar was made and it got copied over into the about page.
If they are on the about page then there is no way to return to the main site. Additionally, I would be annoyed by getting extra tabs in the process while we are on the same site. It makes sense for the external links so that they can stay on our site at least
Contributor
|
I'll be making these changes myself as they are simple and we want to get this deployed faster |
justinrubek
approved these changes
May 16, 2021
justinrubek
left a comment
Contributor
There was a problem hiding this comment.
We are ready to deploy with the navbar fixes. This is all good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The home page (index.html) has been updated with the following:
The About page (learnmore.html) has been updated with the following: