Loops on absolute paths

[maximedenes]

The analyzer loops on absolute paths (e.g. dead_code_analyzer --references /tmp) because of the path normalization function.

I'll submit a tentative fix.

[alainfrisch]

Fixed by #8.

[maximedenes]

I believe you mean "Fixed by #9". Is the fix correct on cygwin? It looks suspicious.

[alainfrisch]

Yes, indeed #9.

And indeed, the patch for this bug is suspicious, I'll look at it again.

[alainfrisch]

Does

  let rec split_path s =
    let open Filename in
    if s = current_dir_name || s = dirname s then [s]
    else (basename s) :: (split_path (dirname s))
  in

look right to you?

[maximedenes]

Yes, I've used that in the past as a termination condition for similar functions, I believe.