master: tclsh script accessing ini file triggers error message in terminal

[Sigma1912]

I have a number of mcodes that access the inifile using tclsh like this example:

#!/usr/bin/tclsh

package require Linuxcnc ;# must be before Hal
emc_init -quick
package require Hal
parse_ini $::env(INI_FILE_NAME)

# Check if correct kinematic is active
if {[hal getp encdisconnect.c.mode-is-rotary] == "FALSE"} {
   puts "mode does not match! Are you calling M120 instead of M420?"
   exit 1
}

# Set rotary parameters
hal setp   hm2_7i95.0.stepgen.04.dirsetup        [set ::JOINT_2(DIRSETUP)]
hal setp   hm2_7i95.0.stepgen.04.dirhold         [set ::JOINT_2(DIRHOLD)]
hal setp   hm2_7i95.0.stepgen.04.steplen         [set ::JOINT_2(STEPLEN)]
hal setp   hm2_7i95.0.stepgen.04.stepspace       [set ::JOINT_2(STEPSPACE)]
hal setp   hm2_7i95.0.stepgen.04.position-scale  [set ::JOINT_2(SCALE)]
hal setp   hm2_7i95.0.stepgen.04.step_type       0
hal setp   hm2_7i95.0.stepgen.04.control-type    1
hal setp   hm2_7i95.0.stepgen.04.maxaccel        [set ::JOINT_2(STEPGEN_MAX_ACC)]
hal setp   hm2_7i95.0.stepgen.04.maxvel          [set ::JOINT_2(STEPGEN_MAX_VEL)]

Execution of these mcodes on current master produces this error:

emc.ini: error: Cannot open ini-file (errno=2 (No such file or directory))

@BsAtHome You might have an idea as this is related to ini file parsing.

[grandixximo]

I think I moved that error, will check if it was my doing...

Edit:
Wasn't me, I moved the other error that shows on startup if the INI file is missing.

[BsAtHome]

The error indicates that it is looking for the default "emc.ini" file, which does not exist.

You import from $::env(INI_FILE_NAME), but that is not changing the load. Therefore, my guess is that the environment variable is not set or contains "emc.ini".

Can you please check what the environment is set to? Maybe do a puts line in the script.

Alternative test is to change the start of the script to do an explicit load of the ini-file before Tcl does the parse into the namespace:

package require Linuxcnc ;# must be before Hal
emc_init -quick
package require Hal
if {![emc_ini_load $::env(INI_FILE_NAME)]} {
    puts "parse_ini: fatal: cannot parse (${::env(INI_FILE_NAME)})."
    exit 1
}
parse_ini $::env(INI_FILE_NAME)
...

[Sigma1912]

I'm sorry I need to make a correction to this report:
The tclsh scripts are actually working (ie the ini file values are read just fine).

The issue is that, for some reason they trigger an error message in the terminal when executing.

emc.ini: error: Cannot open ini-file (errno=2 (No such file or directory))`

[BsAtHome]

The reason for it is that you call emc_init without the -ini option before doing a parse_ini.

The real problem is dragging along a lot of legacy... There is a default ini-filename "emc.ini" hard-coded in the code in a global variable named emc_inifile. When this value is not changed before executing code,... you get the idea.

The emc_init will load the inifile named by the internal variable emc_inifile by invoking the new inifile parser. This will contain the wrong name (emc.ini) and the parser correctly complains that it cannot read that file. Then later on, you do a parse_ini with the right inifile and a local hack in that function does a fixup and all things work out.

You may want to try this fix:

...
emc_init -ini $::env(INI_FILE_NAME) -quick
...

[Sigma1912]

Yes, that works. Thank you.