pncconf: don't refer to kernel_version when not is_kernelspace#184
Merged
Conversation
close LinuxCNC#159 Signed-off-by: Jeff Epler <jepler@unpythonic.net>
Contributor
Author
|
@c-morley let me know if you have any concerns about merging this, otherwise I'll do it in the next week or so. |
Contributor
Author
|
haha in the next week or so. how's 6 months sound? |
This was referenced Oct 29, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to fix #159. Tested on an XU4 (no mesa board actually attached), now it works to open the "tune" windows (but nothing can be done since there's no board attached)