Skip to content

don't bundle yapps2#406

Closed
jepler wants to merge 1 commit into
LinuxCNC:masterfrom
jepler:no-bundled-yapps
Closed

don't bundle yapps2#406
jepler wants to merge 1 commit into
LinuxCNC:masterfrom
jepler:no-bundled-yapps

Conversation

@jepler

@jepler jepler commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

.. there seems to be no reason to do this.

@SebKuzminsky SebKuzminsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some yapps files in lib/python. Removed in an updated version of no-bundled-yapps i pushed to https://github.com/linuxcnc/linuxcnc.

@jepler

jepler commented Feb 3, 2018

Copy link
Copy Markdown
Contributor Author

@SebKuzminsky I see that I left 80% of the task unfinished. feel free to just squash my commit into yours and merge. thanks!

@SebKuzminsky

Copy link
Copy Markdown
Collaborator

I merged a version of this branch into master at be22b73.

@jepler jepler deleted the no-bundled-yapps branch February 4, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants