Skip to content

moved saveToolTable form iocontrol to tool_parse.cc, removed old tool…#415

Closed
rene-dev wants to merge 10 commits into
LinuxCNC:masterfrom
rene-dev:tooltable-cleanup
Closed

moved saveToolTable form iocontrol to tool_parse.cc, removed old tool…#415
rene-dev wants to merge 10 commits into
LinuxCNC:masterfrom
rene-dev:tooltable-cleanup

Conversation

@rene-dev

@rene-dev rene-dev commented Mar 4, 2018

Copy link
Copy Markdown
Member

…table file syntax, added pocketno to tooltable struct so non-random changers report the correct pocket number. should fix #500

Signed-off-by: Rene Hopf renehopf@mac.com

…table file syntax, added pocketno to tooltable struct so non-random changers report the correct pocket number. should fix LinuxCNC#500

Signed-off-by: Rene Hopf <renehopf@mac.com>
rene-dev and others added 7 commits March 4, 2018 15:24
Signed-off-by: Rene Hopf <renehopf@mac.com>
Signed-off-by: Norbert Schechner <nieson@web.de>
Signed-off-by: Rene Hopf <renehopf@mac.com>
Signed-off-by: Rene Hopf <renehopf@mac.com>
Signed-off-by: Rene Hopf <renehopf@mac.com>
@rene-dev

rene-dev commented Mar 4, 2018

Copy link
Copy Markdown
Member Author

Still work in progress....

…t it

Signed-off-by: Rene Hopf <renehopf@mac.com>
@maknoll

maknoll commented May 26, 2018

Copy link
Copy Markdown

I am currently implementing a rack toolchanger wich is managed with pockets and M6 remap.
I fell over that problem and am glad that you already have a fix for it. I hope this gets merged quickly.

Just wanted to comment that there are people out here with ATCs on LinuxCNC machines and this is an actual issue.
With a modern CAD-CAM workflow it is unreasonable to do toolnumber==pocket, random ATC or not.

@rene-dev

Copy link
Copy Markdown
Member Author

It needs testing. the one bug in this PR is, that remapped T do not work for some reason.
but IMHO a T code should never be remapped, as prepare should happen in the background, and not block.

@maknoll

maknoll commented May 27, 2018

Copy link
Copy Markdown

I have applied this PR to master, built it, and it now runs in our mill. It indeed fixes all issues and ATC now finally runs on Pockets. I will report if i suffer any additional bugs.

I agree that T remap is unreasonable. Would rather have the pocket issue fixed and open this one instead.

@rene-dev

Copy link
Copy Markdown
Member Author

you are using a M6 remap only?

@maknoll

maknoll commented May 27, 2018

Copy link
Copy Markdown

Yes, no toolchange preparation whatsoever. Just move to tool location and pick up.

@rene-dev

Copy link
Copy Markdown
Member Author

ok, please check if all numbers match, including while loading-only and unloading-only a tool, by changing to and from tool 0.
Also check if the parameters, are right: http://linuxcnc.org/docs/html/gcode/overview.html#sub:system-parameters
for selected and current tool and pocket.
and, if the stuff passed to python is correct. IMHO you dont need those, as they are available as parameters...

@andypugh

andypugh commented May 27, 2018 via email

Copy link
Copy Markdown
Collaborator

Signed-off-by: Rene Hopf <renehopf@mac.com>

# Conflicts:
#	nc_files/remap_lib/python-stdglue/stdglue.py
@rene-dev

Copy link
Copy Markdown
Member Author

Ah, thanks andy, that makes sense. I will look into why it doesn't work.

@rene-dev rene-dev added the for-discussion-only This pull request is intended as a basis for discussion, not to be merged as-is label Nov 5, 2018
@rene-dev

Copy link
Copy Markdown
Member Author

I created a new pull request to 2.7: #528

@rene-dev rene-dev closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for-discussion-only This pull request is intended as a basis for discussion, not to be merged as-is

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants