Skip to content

CI: Set timeouts so it doesn't run forever#4207

Merged
grandixximo merged 1 commit into
LinuxCNC:masterfrom
hdiethelm:ci_timeout
Jun 28, 2026
Merged

CI: Set timeouts so it doesn't run forever#4207
grandixximo merged 1 commit into
LinuxCNC:masterfrom
hdiethelm:ci_timeout

Conversation

@hdiethelm

@hdiethelm hdiethelm commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Timeout set roughly to 3x the normal runtime and some spare. Mainly due to Sid runs for hours lately due to an issue.

This might generate issues in the future if the runtime increases or also just sometime takes longer due to github being github. But it is easy to fix, just increase the timeout.

@hdiethelm

Copy link
Copy Markdown
Contributor Author

Let's wait for an hour if sid timeouts and then it is ready from my side.

@hdiethelm

hdiethelm commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

It works, ready to merge.
grafik

@hdiethelm hdiethelm marked this pull request as ready for review June 28, 2026 12:00
@grandixximo

Copy link
Copy Markdown
Contributor

I think 30min is a bit too restrictive, when we do our Sunday meetings, we merge a lot of stuff, and the CI can take 45min or more in some cases, might have to go back to Sunday's records to get a better estimate of what good runs look like when the CI is busy.

Timeout set roughly to 3x the normal runtime and some spare.

This results in 45...74 min.
@hdiethelm

hdiethelm commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

I think 30min is a bit too restrictive, when we do our Sunday meetings, we merge a lot of stuff, and the CI can take 45min or more in some cases, might have to go back to Sunday's records to get a better estimate of what good runs look like when the CI is busy.

This timeouts are per job. So if a job is not started due to now CI runners are available, this should not trigger. The numbers to consider are these:
grafik

However, I added more time all over for good measure in the case github is just slow.

@hdiethelm

hdiethelm commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

This one for example took 60 min:
https://github.com/LinuxCNC/linuxcnc/actions/runs/28195580154
But when you look at the run time:
https://github.com/LinuxCNC/linuxcnc/actions/runs/28195580154/usage
It would not have time-outed. But having a bit more time won't hurt to much.

But it is for sure better than the actual default 6h timeout. Right now, we could run out of runners quite fast if many people push.

@grandixximo

Copy link
Copy Markdown
Contributor

Ok, merging, we can roll back or extend if necessary

@grandixximo grandixximo merged commit 3d22c53 into LinuxCNC:master Jun 28, 2026
13 of 15 checks passed
@BsAtHome

Copy link
Copy Markdown
Contributor

The reason for Sid to stall is due to a build error in LinuxCNC. Sid upgraded Python to 3.14 and the boost_python library provides both a compatibility library libboost_python313 and the new libboost_python314. The configure script erroneously selects the wrong library and milltask crashes.

@hdiethelm

Copy link
Copy Markdown
Contributor Author

It's probably still a good idea to timeout CI runs after some time to not stall others. This is also the reason I added it everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants