Skip to content

halcompile - add extralib field to comp file#7

Closed
ArcEye wants to merge 1 commit into
LinuxCNC:masterfrom
ArcEye:master
Closed

halcompile - add extralib field to comp file#7
ArcEye wants to merge 1 commit into
LinuxCNC:masterfrom
ArcEye:master

Conversation

@ArcEye

@ArcEye ArcEye commented Nov 9, 2014

Copy link
Copy Markdown
Contributor

Added extralib field to comp file
Allows linking to custom libs and non-standard lib paths
with halcompile
For userspace components only, exits with error is used
with rt component

Signed-off-by: Mick Grant arceye@mgware.co.uk

Added extralib field to comp file
Allows linking to custom libs and non-standard lib paths
with halcompile
For userspace components only, exits with error is used
with rt component

Signed-off-by: Mick Grant <arceye@mgware.co.uk>
@jepler jepler closed this Nov 14, 2014
@jepler

jepler commented Nov 14, 2014

Copy link
Copy Markdown
Contributor

While reviewing this pull request, I noticed that there was already an unfinished ability to do this, though with a different syntax and different limitations. I fixed it, and added a test and documentation. Starting in the next 2.6 release, you will be able to specify extra link-time arguments, such as additional libraries using the syntax

option extra_link_args "-lm";

@jepler

jepler commented Nov 14, 2014

Copy link
Copy Markdown
Contributor

(this in no way reflects negatively on your contribution; I hope you'll consider offering more contributions in the future)

@ArcEye

ArcEye commented Nov 14, 2014

Copy link
Copy Markdown
Contributor Author

jepler wrote:
"
While reviewing this pull request, I noticed that there was already an unfinished ability to do this, though with a different syntax and different limitations. I fixed it, and added a test and documentation. Starting in the next 2.6 release, you will be able to specify extra link-time arguments, such as additional libraries using the syntax

option extra_link_args "-lm"; "

That explains the presence of the extra_link_args. I searched high and low to see where they originated, as that was the obvious place to insert them, but could not find them.
Presumably python does not care and just creates a blank string which does nothing in the existing
(now superseded) version

robEllenberg pushed a commit to robEllenberg/linuxcnc-mirror that referenced this pull request Jan 19, 2015
4495f3e Merge pull request LinuxCNC#8 from strahlex/newfield
23ca9da machinetalk-protobuf: added name field to config
db74406 Merge pull request LinuxCNC#7 from strahlex/includefix
ee81808 machinetalk-protobuf: rename ERROR to fix aliasing on Windows
a947f40 machinetalk-protobuf: disable proto.js compiler per default
8db45ae machinetalk-protobuf: remvoed unused include to fix warnings with protoc 2.6

git-subtree-dir: src/machinetalk/proto
git-subtree-split: 4495f3e
hansu referenced this pull request in hansu/linuxcnc Apr 7, 2022
docs: Removed redundant 'sec:tool-table' anchor
docs: fix anchors
@pcw-mesa pcw-mesa mentioned this pull request Nov 4, 2022
@zz912 zz912 mentioned this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants