feat!: move the executor API to ./executor, drop ./core (A3) - #397
Merged
Merged
Conversation
LinuxDevil
force-pushed
the
lou-a2c-remove-delegate
branch
from
October 4, 2026 12:44
80ef674 to
d64750e
Compare
LinuxDevil
force-pushed
the
lou-a3-executor-subpath
branch
from
October 4, 2026 12:47
8e5c44f to
a32fc57
Compare
AgentBuilder, AgentExecutor, ExecuteOptions, resumeAfterApproval, streamResumeAfterApproval, resumeRequest, ResumeExecuteOptions, ResumeRequest, ToolRegistry and globalToolRegistry moved out of the package root to the new '@lousho/build-ai-agent/executor' entry point. ToolRegistry stays on '@lousho/build-ai-agent/tools' too; the two entries share one binding. The './core' subpath is removed (src/core/ stays for internal imports). ExecutionResult and ExecutionFinishReason stay on the root - createAgent()'s public types use them. Root exports: 696 -> 686 (-10). Closes #240
LinuxDevil
force-pushed
the
lou-a3-executor-subpath
branch
from
October 4, 2026 12:49
a32fc57 to
35dd8b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240
What
Moves the lower-level executor API out of the package root to a new
@lousho/build-ai-agent/executorentry point, so the import path says what the docs already teach:createAgent()is the default, the executor is advanced.Moved off the root (10 names):
AgentExecutor,type ExecuteOptionsAgentBuilderresumeAfterApproval,streamResumeAfterApproval,resumeRequesttype ResumeExecuteOptions,type ResumeRequestToolRegistry,globalToolRegistryStill exported where expected:
ExecutionResultandExecutionFinishReasonstay on the root (createAgent()'s public types use them) and are re-exported from./executor.ToolRegistry/globalToolRegistrystay on@lousho/build-ai-agent/tools;./executorand./toolsshare one binding (verified bysharedChunks.test.tsfor both ESM and CJS)../coreis removed fromexports,tsupentries anddist/;src/core/stays for internal imports/tests.Root export count
696 -> 686 (-10, measured via the TypeScript compiler API over
src/index.ts)../executorexports the 12 listed names.Verified
npm run typecheck,npm run lintcleannpm run build:dist/executor/index.{js,mjs,d.ts,d.mts}emitted;dist/core/gonenpx vitest run: 294 files, 4268 tests pass (incl.importGraph,sharedChunks,publicSurface)npm run test:types: 18 files, 88 type tests, no errorsnpm run docs:verify-snippets -- --skip-build: 257 snippets, all type-check; 8 runnable passnpm run pack-smoke: all functional checks pass (19/19 ESM + CJS entries, tsc resolution under bundler and node16)typecheck,lint(0 errors),test(119),test:server(133),buildall passnpm run docs:llmsregenerated; acceptance grep for root executor imports is cleanDeviations
pack-smokereports two pre-existing threshold failures (tarball 921 entries > 900, 16.87 MB > 16 MB). A3's file delta is net zero indist(dist/core->dist/executor) and +2 files insrc/; the limits were already exceeded before this change.npm run buildneededNODE_OPTIONS=--max-old-space-size=12288locally for the tsup DTS worker (heap OOM at the default limit).Migration note added to CHANGELOG under Unreleased > Breaking.