LizardByte · ReenigneArcher · Sep 2, 2026 · Jun 20, 2026 · Sep 2, 2026 · Sep 2, 2026
diff --git a/src/round_robin.h b/src/round_robin.h
@@ -280,7 +280,7 @@ namespace round_robin_util {
   /**
    * @brief Iterator that cycles indefinitely over a fixed begin/end range.
    */
-  template<class V, class It>
+  template<class V, std::random_access_iterator It>
   class round_robin_t: public it_wrap_t<V, round_robin_t<V, It>> {
   public:
     /**
@@ -329,11 +329,21 @@ namespace round_robin_util {
     /**
      * @brief Compare two iterators for equality.
      *
-     * @param other Iterator or container to compare against.
-     * @return True when both iterators point to equivalent values.
+     * @param other Iterator to compare against.
+     * @return True when both iterators refer to the same position.
      */
     bool eq(const round_robin_t &other) const {
-      return *_pos == *other._pos;
+      return _pos == other._pos;
+    }
+
+    /**
+     * @brief Compare two iterators by their positions in the wrapped range.
+     *
+     * @param other Iterator to compare against.
+     * @return True when this iterator follows `other` in the wrapped range.
+     */
+    bool gt(const round_robin_t &other) const {
+      return _pos > other._pos;
     }
 
     /**
@@ -359,7 +369,7 @@ namespace round_robin_util {
    * @param end Iterator or pointer marking the end of the input range.
    * @return Iterator initialized to `begin` and wrapping before `end`.
    */
-  template<class V, class It>
+  template<class V, std::random_access_iterator It>
   round_robin_t<V, It> make_round_robin(It begin, It end) {
     return round_robin_t<V, It>(begin, end);
   }

diff --git a/src/stat_trackers.h b/src/stat_trackers.h
@@ -5,7 +5,9 @@
 #pragma once
 
 // standard includes
+#include <algorithm>
 #include <chrono>
+#include <cstdint>
 #include <functional>
 #include <limits>
 
@@ -70,7 +72,7 @@ namespace stat_trackers {
     struct {
       std::chrono::steady_clock::time_point last_callback_time = std::chrono::steady_clock::now();
       T stat_min = std::numeric_limits<T>::max();
-      T stat_max = std::numeric_limits<T>::min();
+      T stat_max = std::numeric_limits<T>::lowest();
       double stat_total = 0;
       uint32_t calls = 0;
     } data;

diff --git a/src/utility.h b/src/utility.h
@@ -7,6 +7,7 @@
 // standard includes
 #include <algorithm>
 #include <condition_variable>
+#include <cstddef>
 #include <memory>
 #include <mutex>
 #include <optional>
@@ -394,10 +395,10 @@ namespace util {
 
     buf.reserve(data_len);
 
-    auto *data = (uint8_t *) &_struct;
+    auto const *data = reinterpret_cast<std::byte const *>(&_struct);
 
     for (size_t x = 0; x < data_len; ++x) {
-      buf.push_back(data[x]);
+      buf.push_back(std::to_integer<uint8_t>(data[x]));
     }
   }
 
@@ -568,6 +569,10 @@ namespace util {
     std::string hex;
     hex.resize(str_size);
 
+    if (begin == end) {
+      return hex;
+    }
+
     const char _bits[16] {
       '0',
       '1',

diff --git a/tests/integration/test_config_consistency.cpp b/tests/integration/test_config_consistency.cpp
@@ -2,6 +2,8 @@
  * @file tests/integration/test_config_consistency.cpp
  * @brief Test configuration consistency across all configuration files
  */
+
+// test includes
 #include "../tests_common.h"
 
 // standard includes

diff --git a/tests/integration/test_external_commands.cpp b/tests/integration/test_external_commands.cpp
@@ -2,6 +2,8 @@
  * @file tests/integration/test_external_commands.cpp
  * @brief Integration tests for running external commands with platform-specific validation
  */
+
+// test includes
 #include "../tests_common.h"
 
 // standard includes

diff --git a/tests/integration/test_locale_consistency.cpp b/tests/integration/test_locale_consistency.cpp
@@ -2,6 +2,8 @@
  * @file tests/integration/test_locale_consistency.cpp
  * @brief Test locale consistency across configuration files and locale JSON files
  */
+
+// test includes
 #include "../tests_common.h"
 
 // standard includes

diff --git a/tests/tests_common.h b/tests/tests_common.h
@@ -4,6 +4,11 @@
  */
 #pragma once
 
+// standard includes
+#include <memory>
+#include <string>
+#include <utility>
+
 // Suppress false positive warnings in Boost.Asio on some GCC versions (particularly Arch Linux)
 // These are known false positives in Boost.Asio's basic_resolver_results.hpp
 #if defined(__GNUC__) && !defined(__clang__)
@@ -12,7 +17,10 @@
   #pragma GCC diagnostic ignored "-Wstringop-overflow"
 #endif
 
+// lib includes
 #include <lizardbyte/common/testing.h>
+
+// local includes
 #include <src/globals.h>
 #include <src/logging.h>
 #include <src/platform/common.h>

diff --git a/tests/tests_environment.h b/tests/tests_environment.h
@@ -3,6 +3,8 @@
  * @brief Declarations for SunshineEnvironment.
  */
 #pragma once
+
+// test includes
 #include "tests_common.h"
 
 struct SunshineEnvironment: testing::Environment {

diff --git a/tests/tests_events.h b/tests/tests_events.h
@@ -3,6 +3,8 @@
  * @brief Declarations for SunshineEventListener.
  */
 #pragma once
+
+// test includes
 #include "tests_common.h"
 
 struct SunshineEventListener: BufferedTestEventListener {

diff --git a/tests/tests_log_checker.h b/tests/tests_log_checker.h
@@ -4,11 +4,15 @@
  */
 #pragma once
 
+// standard includes
 #include <algorithm>
 #include <fstream>
 #include <regex>
-#include <src/logging.h>
 #include <string>
+#include <string_view>
+
+// local includes
+#include <src/logging.h>
 
 namespace log_checker {
 

diff --git a/tests/tests_main.cpp b/tests/tests_main.cpp
@@ -2,6 +2,8 @@
  * @file tests/tests_main.cpp
  * @brief Entry point definition.
  */
+
+// test includes
 #include "tests_common.h"
 #include "tests_environment.h"
 #include "tests_events.h"

diff --git a/tests/unit/platform/linux/test_wayland.cpp b/tests/unit/platform/linux/test_wayland.cpp
@@ -3,8 +3,10 @@
  * @brief Test Wayland output mode selection.
  */
 #ifdef SUNSHINE_BUILD_WAYLAND
+  // test includes
   #include "../../../tests_common.h"
 
+  // local includes
   #include <src/platform/linux/wayland.h>
 
 TEST(WaylandMonitorTest, IgnoresNonCurrentModesAroundCurrentMode) {

diff --git a/tests/unit/platform/test_common.cpp b/tests/unit/platform/test_common.cpp
@@ -2,9 +2,14 @@
  * @file tests/unit/platform/test_common.cpp
  * @brief Test src/platform/common.*.
  */
+
+// test includes
 #include "../../tests_common.h"
 
+// lib includes
 #include <boost/asio/ip/host_name.hpp>
+
+// local includes
 #include <src/platform/common.h>
 
 TEST(HostnameTests, TestAsioEquality) {

diff --git a/tests/unit/platform/test_virtualhid_input.cpp b/tests/unit/platform/test_virtualhid_input.cpp
@@ -2,6 +2,8 @@
  * @file tests/unit/platform/test_virtualhid_input.cpp
  * @brief Tests for shared libvirtualhid input helpers.
  */
+
+// test includes
 #include "../../tests_common.h"
 
 // standard includes

diff --git a/tests/unit/platform/windows/test_audio.cpp b/tests/unit/platform/windows/test_audio.cpp
@@ -3,15 +3,20 @@
  * @brief Tests for Windows audio sink selection and endpoint-change handling.
  */
 
+// test includes
 #include "../../../tests_common.h"
 
 #ifdef _WIN32
-  #include "src/platform/common.h"
-
+  // standard includes
   #include <cstring>
+
+  // platform includes
   #include <mmdeviceapi.h>
   #include <propsys.h>
 
+  // local includes
+  #include "src/platform/common.h"
+
 namespace platf::audio::tests {
   bool sink_device_available(const std::string &sink, IMMDeviceEnumerator *device_enum);
   bool microphone_available(const std::string &assigned_sink, const std::string &configured_sink, IMMDeviceEnumerator *device_enum);

diff --git a/tests/unit/platform/windows/test_utf_utils.cpp b/tests/unit/platform/windows/test_utf_utils.cpp
@@ -2,14 +2,20 @@
  * @file tests/unit/platform/windows/test_utf_utils.cpp
  * @brief Test src/platform/windows/utf_utils.cpp UTF conversion functions.
  */
+
+// test includes
 #include "../../../tests_common.h"
 
+// standard includes
 #include <iostream>
 #include <string>
 
 #ifdef _WIN32
-  #include <src/platform/windows/utf_utils.h>
+  // platform includes
   #include <Windows.h>
+
+  // local includes
+  #include <src/platform/windows/utf_utils.h>
 #endif
 
 #ifdef _WIN32

diff --git a/tests/unit/test_audio.cpp b/tests/unit/test_audio.cpp
@@ -2,8 +2,11 @@
  * @file tests/unit/test_audio.cpp
  * @brief Test src/audio.*.
  */
+
+// test includes
 #include "../tests_common.h"
 
+// local includes
 #include <src/audio.h>
 
 using namespace audio;

diff --git a/tests/unit/test_confighttp.cpp b/tests/unit/test_confighttp.cpp
@@ -7,7 +7,7 @@
  * verify that the confighttp functions work correctly end-to-end.
  */
 
-// test imports
+// test includes
 #include "../tests_common.h"
 
 // standard includes
@@ -20,12 +20,12 @@
 #include <thread>
 #include <utility>
 
-// lib imports
+// lib includes
 #include <Simple-Web-Server/client_https.hpp>
 #include <Simple-Web-Server/crypto.hpp>
 #include <Simple-Web-Server/server_https.hpp>
 
-// local imports
+// local includes
 #include <src/config.h>
 #include <src/confighttp.h>
 #include <src/crypto.h>

diff --git a/tests/unit/test_crypto.cpp b/tests/unit/test_crypto.cpp
@@ -2,13 +2,13 @@
  * @file tests/unit/test_crypto.cpp
  * @brief Test src/crypto.*.
  */
-// test imports
+// test includes
 #include "../tests_common.h"
 
-// lib imports
+// lib includes
 #include <openssl/x509.h>
 
-// local imports
+// local includes
 #include <src/crypto.h>
 
 TEST(CryptoTest, GeneratedCredentialsExposeSubjectAndVerifySignatures) {

diff --git a/tests/unit/test_display_device.cpp b/tests/unit/test_display_device.cpp
@@ -2,9 +2,14 @@
  * @file tests/unit/test_display_device.cpp
  * @brief Test src/display_device.*.
  */
+
+// test includes
 #include "../tests_common.h"
 
+// standard includes
 #include <format>
+
+// local includes
 #include <src/config.h>
 #include <src/display_device.h>
 #include <src/rtsp.h>

diff --git a/tests/unit/test_entry_handler.cpp b/tests/unit/test_entry_handler.cpp
@@ -2,9 +2,12 @@
  * @file tests/unit/test_entry_handler.cpp
  * @brief Test src/entry_handler.*.
  */
+
+// test includes
 #include "../tests_common.h"
 #include "../tests_log_checker.h"
 
+// local includes
 #include <src/entry_handler.h>
 
 TEST(EntryHandlerTests, LogPublisherDataTest) {

diff --git a/tests/unit/test_file_handler.cpp b/tests/unit/test_file_handler.cpp
@@ -2,9 +2,14 @@
  * @file tests/unit/test_file_handler.cpp
  * @brief Test src/file_handler.*.
  */
+
+// test includes
 #include "../tests_common.h"
 
+// standard includes
 #include <format>
+
+// local includes
 #include <src/file_handler.h>
 
 struct FileHandlerParentDirectoryTest: BaseTest, testing::WithParamInterface<std::tuple<std::string, std::string>> {};

diff --git a/tests/unit/test_http_pairing.cpp b/tests/unit/test_http_pairing.cpp
@@ -3,8 +3,10 @@
  * @brief Test src/nvhttp.cpp HTTP pairing process
  */
 
+// test includes
 #include "../tests_common.h"
 
+// local includes
 #include <src/nvhttp.h>
 
 using namespace nvhttp;

diff --git a/tests/unit/test_httpcommon.cpp b/tests/unit/test_httpcommon.cpp
@@ -2,13 +2,13 @@
  * @file tests/unit/test_httpcommon.cpp
  * @brief Test src/httpcommon.*.
  */
-// test imports
+// test includes
 #include "../tests_common.h"
 
-// lib imports
+// lib includes
 #include <curl/curl.h>
 
-// local imports
+// local includes
 #include <src/httpcommon.h>
 
 struct UrlEscapeTest: BaseTest, testing::WithParamInterface<std::tuple<std::string, std::string>> {};