Skip to content

perf(deps): switch to upstream nanors runtime dispatching - #5369

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
cgutman:nanors_rd
Jul 4, 2026
Merged

perf(deps): switch to upstream nanors runtime dispatching#5369
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
cgutman:nanors_rd

Conversation

@cgutman

@cgutman cgutman commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Nanors has implemented their own runtime dispatching so our rswrapper hack is no longer required to use more advanced ISA extensions. In addition to runtime dispatching, they have also implemented a number of new handwritten assembly routines to improve performance on x64, ARM64, and RISC-V (GFNI, NEON, and RVV).

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@cgutman

cgutman commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

@ReenigneArcher Any clue what's up with the Arch and Flatpak builds?

@ReenigneArcher

Copy link
Copy Markdown
Member

@ReenigneArcher Any clue what's up with the Arch and Flatpak builds?

Yes, it randomly fails to checkout the ref. I think I have to revert it to checking out the fork branch directly.

For now, it can usually be resolved by forcing a push (though the hash must change).

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.04%. Comparing base (92a9230) to head (ceb0a0d).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
- Coverage   27.45%   27.04%   -0.42%     
==========================================
  Files         113      111       -2     
  Lines       25554    25853     +299     
  Branches    11244    11470     +226     
==========================================
- Hits         7016     6991      -25     
- Misses      15538    16951    +1413     
+ Partials     3000     1911    -1089     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.21% <ø> (-0.04%) ⬇️
Homebrew-macos-14 20.93% <ø> (-0.08%) ⬇️
Homebrew-macos-15 21.08% <ø> (-0.09%) ⬇️
Homebrew-macos-26 21.20% <ø> (-0.09%) ⬇️
Homebrew-ubuntu-24.04 12.98% <ø> (-0.03%) ⬇️
Linux-AppImage 12.31% <ø> (-0.03%) ⬇️
Windows-AMD64 15.24% <ø> (-0.03%) ⬇️
Windows-ARM64 13.27% <ø> (-0.04%) ⬇️
macOS-arm64 19.22% <ø> (-0.06%) ⬇️
macOS-x86_64 18.73% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stream.cpp 22.56% <ø> (ø)

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9230...ceb0a0d. Read the comment docs.

Comment thread third-party/moonlight-common-c
Comment thread src/main.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants