build(Linux): Allow building with Vulkan but without Wayland - #5377
Merged
Conversation
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
ReenigneArcher
force-pushed
the
no-wayland
branch
from
July 5, 2026 18:41
f06cc23 to
aa520ac
Compare
ReenigneArcher
approved these changes
Jul 5, 2026
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5377 +/- ##
==========================================
- Coverage 27.18% 27.18% -0.01%
==========================================
Files 111 111
Lines 25412 25412
Branches 11214 11214
==========================================
- Hits 6909 6908 -1
+ Misses 16632 16571 -61
- Partials 1871 1933 +62
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
This was referenced Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build fails otherwise due to a missing include.
The generated-src idea could potentially be used for any platform, so include it in the common file.On a side note, the build also fails with PipeWire but without Wayland due to Wayland-specific code in pipeline.cpp. The EGL bits could be adapted, but the monitor handling is more involved, so I figured this wasn't worth the effort.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage