Skip to content

chore(sonar): change NOSONAR comment style - #5410

Merged
ReenigneArcher merged 2 commits into
masterfrom
chore/sonar/change-nosonar-comment-style
Jul 13, 2026
Merged

chore(sonar): change NOSONAR comment style#5410
ReenigneArcher merged 2 commits into
masterfrom
chore/sonar/change-nosonar-comment-style

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Standardize NOSONAR comments with our other repos.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Remove NOSONAR suppression comments from curl_easy_init and CURLOPT_SSLVERSION calls in download_file function.
@ReenigneArcher
ReenigneArcher force-pushed the chore/sonar/change-nosonar-comment-style branch from 7fda800 to 577ff9d Compare July 13, 2026 20:19
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.70%. Comparing base (0d1dfe4) to head (577ff9d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/config.cpp 0.00% 1 Missing ⚠️
src/platform/linux/vaapi.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5410      +/-   ##
==========================================
- Coverage   26.71%   26.70%   -0.01%     
==========================================
  Files         111      111              
  Lines       25329    25329              
  Branches    11197    11198       +1     
==========================================
- Hits         6766     6765       -1     
+ Misses      17065    16725     -340     
- Partials     1498     1839     +341     
Flag Coverage Δ
Archlinux 0.00% <0.00%> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.20% <50.00%> (ø)
Homebrew-macos-14 20.35% <66.66%> (ø)
Homebrew-macos-15 20.51% <66.66%> (-0.02%) ⬇️
Homebrew-macos-26 20.64% <66.66%> (ø)
Homebrew-ubuntu-24.04 12.93% <50.00%> (ø)
Linux-AppImage 12.27% <50.00%> (ø)
Windows-AMD64 15.20% <66.66%> (ø)
Windows-ARM64 13.25% <66.66%> (ø)
macOS-arm64 17.69% <100.00%> (ø)
macOS-x86_64 18.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/httpcommon.cpp 49.62% <100.00%> (ø)
src/nvhttp.cpp 33.46% <ø> (ø)
src/config.cpp 24.00% <0.00%> (ø)
src/platform/linux/vaapi.cpp 2.84% <0.00%> (ø)

... and 55 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1dfe4...577ff9d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant