Skip to content

fix(web-ui): Welcome page styling - #5466

Merged
ReenigneArcher merged 5 commits into
LizardByte:masterfrom
Noklef:homepage-css-fix
Aug 7, 2026
Merged

fix(web-ui): Welcome page styling#5466
ReenigneArcher merged 5 commits into
LizardByte:masterfrom
Noklef:homepage-css-fix

Conversation

@Noklef

@Noklef Noklef commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

  • Created a shared NavbarSimple component for the unauth'd welcome / logout page routes
  • Updated the Welcome page with the app consistent style & layout, Navbar, updated login button size, and remove unnecessary subheading
  • Updated the logout page to include a Navbar
  • Removed string reference related to the removed subheading

Screenshot

image image

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Noklef added 5 commits August 1, 2026 17:51
…st of the UI

- Added small simple navbar component (with theme options / logo) to conform to the other pages
- Changed login button to look similar to logout's `Login` button
- Moved header / sub-heading out of card
@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher changed the title fix(web-ui): Fix / update Welcome page + navbar for Logout page fix(web-ui): Welcome page styling Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 435 bytes (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 860.21kB 435 bytes (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/logo-*.js (New) 379.6kB 379.6kB 100.0% 🚀
assets/logo-*.css (New) 281.0kB 281.0kB 100.0% 🚀
assets/config-*.js -28 bytes 72.18kB -0.04%
assets/index-*.js -28 bytes 45.75kB -0.06%
assets/featured-*.js -28 bytes 30.07kB -0.09%
assets/apps-*.js -28 bytes 13.39kB -0.21%
assets/troubleshooting-*.js -28 bytes 9.05kB -0.31%
assets/Navbar-*.js -16.51kB 6.67kB -71.21%
assets/Notification-*.js -69 bytes 2.94kB -2.29%
assets/ResourceCard-*.js -54 bytes 2.59kB -2.04%
assets/pin-*.js -28 bytes 1.7kB -1.62%
assets/welcome-*.js 93 bytes 909 bytes 11.4% ⚠️
assets/NavbarSimple-*.js (New) 796 bytes 796 bytes 100.0% 🚀
assets/password-*.js -28 bytes 752 bytes -3.59%
assets/logout-*.js -312 bytes 178 bytes -63.67%
assets/createLucideIcon-*.js (Deleted) -360.91kB 0 bytes -100.0% 🗑️
assets/createLucideIcon-*.css (Deleted) -281.0kB 0 bytes -100.0% 🗑️
assets/theme-*.js (Deleted) -2.01kB 0 bytes -100.0% 🗑️

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.99%. Comparing base (0784774) to head (06d617c).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5466      +/-   ##
==========================================
+ Coverage   26.71%   27.99%   +1.28%     
==========================================
  Files         109      109              
  Lines       24552    24683     +131     
  Branches    10764    10886     +122     
==========================================
+ Hits         6560     6911     +351     
- Misses      14067    16545    +2478     
+ Partials     3925     1227    -2698     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-amd64 13.95% <ø> (-0.02%) ⬇️
Homebrew-macos-14 22.45% <ø> (ø)
Homebrew-macos-15 23.12% <ø> (ø)
Homebrew-macos-26 23.24% <ø> (ø)
Homebrew-ubuntu-24.04 13.90% <ø> (+0.32%) ⬆️
Linux-AppImage 13.31% <ø> (ø)
Windows-AMD64 17.29% <ø> (ø)
Windows-ARM64 14.93% <ø> (-0.01%) ⬇️
macOS-arm64 19.82% <ø> (?)
macOS-x86_64 20.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 74 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0784774...06d617c. Read the comment docs.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Last Updated 2026-08-07 13:44:44 UTC
Source Run CI Run #4865
Commit 06d617ce15daca0657111f86a285901178b80ea2

Screenshot Comparison

PR #5466 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants