Skip to content

chore: update Virtual HID requirements and mouse refresh - #5547

Merged
ReenigneArcher merged 1 commit into
masterfrom
chore/update-libvirtualhid
Aug 23, 2026
Merged

chore: update Virtual HID requirements and mouse refresh#5547
ReenigneArcher merged 1 commit into
masterfrom
chore/update-libvirtualhid

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 23, 2026

Copy link
Copy Markdown
Member

Description

Set a Windows Virtual HID Driver minimum version of 2026.823.352.3 (while still allowing 0.0.0.* development builds), and fix driver detection/status reporting so outdated installs are shown as installed but incompatible. Add runtime mouse recreation after successful license actions, broaden Windows UI/troubleshooting checks beyond controller-enabled mode, and update tray/web/docs messaging to cover Raw Input mouse support and licensing scope. Unit tests were expanded for version logic, mouse refresh behavior, and tray text, and the libvirtualhid submodule was updated.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Set a Windows Virtual HID Driver minimum version of `2026.823.352.3` (while still allowing `0.0.0.*` development builds), and fix driver detection/status reporting so outdated installs are shown as installed but incompatible. Add runtime mouse recreation after successful license actions, broaden Windows UI/troubleshooting checks beyond controller-enabled mode, and update tray/web/docs messaging to cover Raw Input mouse support and licensing scope. Unit tests were expanded for version logic, mouse refresh behavior, and tray text, and the libvirtualhid submodule was updated.
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review August 23, 2026 14:33
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 75 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 879.32kB 75 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 75 bytes 47.14kB 0.16%

Files in assets/index-*.js:

  • ./src_assets/common/assets/web/index.html → Total Size: 0 bytes

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.85%. Comparing base (7a59212) to head (e19464a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/confighttp.cpp 57.14% 2 Missing and 1 partial ⚠️
src/platform/virtualhid_input.cpp 85.71% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5547      +/-   ##
==========================================
+ Coverage   33.81%   33.85%   +0.03%     
==========================================
  Files         104      104              
  Lines       25065    25084      +19     
  Branches    11087    11095       +8     
==========================================
+ Hits         8476     8491      +15     
+ Misses      15629    15607      -22     
- Partials      960      986      +26     
Flag Coverage Δ
Archlinux 0.00% <0.00%> (ø)
FreeBSD-amd64 19.52% <56.52%> (+0.07%) ⬆️
Homebrew-macos-14 30.76% <71.42%> (+0.06%) ⬆️
Homebrew-macos-15 31.47% <71.42%> (+0.06%) ⬆️
Homebrew-macos-26 31.59% <71.42%> (+0.08%) ⬆️
Homebrew-ubuntu-24.04 20.82% <70.00%> (+0.06%) ⬆️
Linux-AppImage 20.21% <70.00%> (+0.03%) ⬆️
Windows-AMD64 25.78% <57.14%> (+0.01%) ⬆️
Windows-ARM64 21.65% <37.50%> (+0.01%) ⬆️
macOS-arm64 25.57% <58.33%> (+0.09%) ⬆️
macOS-x86_64 26.22% <58.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/confighttp.h 100.00% <ø> (ø)
src/input.cpp 30.67% <100.00%> (+0.78%) ⬆️
src/input.h 50.00% <ø> (ø)
src/platform/virtualhid_input.h 0.00% <ø> (ø)
src/system_tray.cpp 80.51% <100.00%> (ø)
src/platform/virtualhid_input.cpp 97.50% <85.71%> (-0.13%) ⬇️
src/confighttp.cpp 54.33% <57.14%> (-0.07%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a59212...e19464a. Read the comment docs.

@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown
Last Updated 2026-08-23 18:44:14 UTC
Source Run CI Run #5078
Commit e19464a8eb1ec49fc3385dc979c356130531706e

Screenshot Comparison

PR #5547 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Games using Raw Input have broken mouse drag/zoom on headless setups with no physical mouse

1 participant