Skip to content

ci: sonar fixes - #5594

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes
Sep 1, 2026
Merged

ci: sonar fixes#5594
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar-fixes

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Sonar fixes for CI/CD.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher added this to the sonar milestone Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Comment thread .github/workflows/ci-flatpak.yml Fixed
Comment thread .github/workflows/ci-freebsd.yml Fixed
Comment thread .github/workflows/ci-freebsd.yml Fixed
Comment thread .github/workflows/ci-macos.yml Fixed
Comment thread .github/workflows/ci-windows.yml Fixed
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.55%. Comparing base (f111d6a) to head (940db21).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5594    +/-   ##
========================================
  Coverage   34.55%   34.55%            
========================================
  Files         104      104            
  Lines       25314    25314            
  Branches    11194    11194            
========================================
  Hits         8748     8748            
+ Misses      14460    14344   -116     
- Partials     2106     2222   +116     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-amd64 19.75% <ø> (+<0.01%) ⬆️
Homebrew-macos-14 31.11% <ø> (ø)
Homebrew-macos-15 31.77% <ø> (ø)
Homebrew-macos-26 31.87% <ø> (+<0.01%) ⬆️
Homebrew-ubuntu-24.04 20.99% <ø> (-0.02%) ⬇️
Linux-AppImage 20.41% <ø> (ø)
Windows-AMD64 27.04% <ø> (ø)
Windows-ARM64 22.82% <ø> (ø)
macOS-arm64 25.98% <ø> (ø)
macOS-x86_64 26.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 22 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f111d6a...940db21. Read the comment docs.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Last Updated 2026-09-01 23:57:24 UTC
Source Run CI Run #5232
Commit 940db219c0d27d0ef92519d53d1ae686f75a07fa

Screenshot Comparison

PR #5594 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
5 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants