refactor: pairing flow, pairing tests, and inline struct comments - #5602
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
ReenigneArcher
force-pushed
the
chore/sonar-fixes
branch
from
September 3, 2026 02:59
a617e7b to
5679995
Compare
ReenigneArcher
marked this pull request as ready for review
September 3, 2026 03:07
Extracted `getservercert` handling into a dedicated pairing-session helper, tightened locking by switching shared mutex globals to accessor-backed statics, and cleaned up several C++ initializations/guards for clarity. Pairing IDs now use explicit hex alphabet generation, config HTTP cancel-pairing now catches JSON-specific exceptions, and test-only HTTP pairing entry points were added. Unit coverage was expanded substantially for HTTP pairing behavior (pending/cancel, duplicate/full capacity, console PIN success/failure/expiration), session removal, and client-auth state assertions.
ReenigneArcher
force-pushed
the
chore/sonar-fixes
branch
from
September 3, 2026 03:27
5679995 to
249081d
Compare
Add `///<` member-level documentation across config, networking, streaming, and platform-specific structs/unions (Linux VAAPI/audio and Windows input/display). This improves code clarity and satisfies stricter Doxygen coverage requirements without changing runtime behavior.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5602 +/- ##
==========================================
+ Coverage 36.84% 37.26% +0.41%
==========================================
Files 104 104
Lines 25852 25880 +28
Branches 11420 11419 -1
==========================================
+ Hits 9526 9644 +118
+ Misses 13442 13428 -14
+ Partials 2884 2808 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #5602 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
This was referenced Sep 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted
getservercerthandling into a dedicated pairing-session helper, tightened locking by switching shared mutex globals to accessor-backed statics, and cleaned up several C++ initializations/guards for clarity. Pairing IDs now use explicit hex alphabet generation, config HTTP cancel-pairing now catches JSON-specific exceptions, and test-only HTTP pairing entry points were added. Unit coverage was expanded substantially for HTTP pairing behavior (pending/cancel, duplicate/full capacity, console PIN success/failure/expiration), session removal, and client-auth state assertions.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.