Skip to content

build(docker): add bake config - #5607

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/docker-fixes
Sep 4, 2026
Merged

build(docker): add bake config#5607
ReenigneArcher merged 1 commit into
masterfrom
build/docker-fixes

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

Introduce a new docker-bake.hcl that defines shared Docker build targets, groups, platform selection, and no-cache filters (including CI_PR handling for PR builds). Dockerfile-specific build metadata comments were removed from the CLion toolchain and Sunshine distro Dockerfiles, centralizing build configuration in Bake instead of inline headers.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.26%. Comparing base (1b9cc97) to head (209f15b).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5607    +/-   ##
========================================
  Coverage   37.26%   37.26%            
========================================
  Files         104      104            
  Lines       25879    25880     +1     
  Branches    11422    11419     -3     
========================================
+ Hits         9643     9644     +1     
+ Misses      13459    13307   -152     
- Partials     2777     2929   +152     
Flag Coverage Δ
Archlinux 20.90% <ø> (ø)
FreeBSD-amd64 23.24% <ø> (ø)
Homebrew-macos-14 36.25% <ø> (?)
Homebrew-macos-15 36.82% <ø> (ø)
Homebrew-macos-26 37.13% <ø> (-0.02%) ⬇️
Homebrew-ubuntu-24.04 24.90% <ø> (ø)
Linux-AppImage 24.33% <ø> (ø)
Windows-AMD64 30.03% <ø> (ø)
Windows-ARM64 25.19% <ø> (+<0.01%) ⬆️
macOS-arm64 30.59% <ø> (ø)
macOS-x86_64 31.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9cc97...209f15b. Read the comment docs.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Last Updated 2026-09-04 13:08:48 UTC
Source Run CI Run #5277
Commit 209f15b7f43404dbde19be152331e831dafc0c7a

Screenshot Comparison

PR #5607 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher force-pushed the build/docker-fixes branch 2 times, most recently from 724bd19 to ccd36a1 Compare September 4, 2026 02:27
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review September 4, 2026 02:28
@ReenigneArcher ReenigneArcher added the roadmap This PR closes a roadmap entry label Sep 4, 2026
Introduce a new `docker-bake.hcl` that defines shared Docker build targets, groups, platform selection, and no-cache filters (including `CI_PR` handling for PR builds). Dockerfile-specific build metadata comments were removed from the CLion toolchain and Sunshine distro Dockerfiles, centralizing build configuration in Bake instead of inline headers.
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 1edbbcd into master Sep 4, 2026
119 of 125 checks passed
@ReenigneArcher
ReenigneArcher deleted the build/docker-fixes branch September 4, 2026 13:12
@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap This PR closes a roadmap entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sunshine: refactor docker builds

1 participant