Skip to content

ci(homebrew): run tests in separate step - #5669

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
ci/homebrew/run-tests-in-separate-step
Draft

ci(homebrew): run tests in separate step#5669
ReenigneArcher wants to merge 1 commit into
masterfrom
ci/homebrew/run-tests-in-separate-step

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Workaround Homebrew/brew#23909 but keep our full tests and coverage results intact.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the ci/homebrew/run-tests-in-separate-step branch 2 times, most recently from ebf02ad to 15180e6 Compare September 10, 2026 03:39
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b55d74c). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5669   +/-   ##
=========================================
  Coverage          ?   37.51%           
=========================================
  Files             ?      104           
  Lines             ?    26016           
  Branches          ?    11482           
=========================================
  Hits              ?     9759           
  Misses            ?    12586           
  Partials          ?     3671           
Flag Coverage Δ
Archlinux 21.08% <ø> (?)
FreeBSD-amd64 23.38% <ø> (?)
Homebrew-macos-14 36.51% <ø> (?)
Homebrew-macos-15 37.07% <ø> (?)
Homebrew-macos-26 37.37% <ø> (?)
Linux-AppImage-aarch64 25.66% <ø> (?)
Linux-AppImage-x86_64 25.87% <ø> (?)
Windows-AMD64 30.18% <ø> (?)
Windows-ARM64 25.32% <ø> (?)
macOS-arm64 30.73% <ø> (?)
macOS-x86_64 31.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55d74c...b869c48. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the ci/homebrew/run-tests-in-separate-step branch from 15180e6 to b869c48 Compare September 10, 2026 04:22
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

Copy link
Copy Markdown
Last Updated 2026-09-10 05:22:33 UTC
Source Run CI Run #5432
Commit b869c4847b75a4b158d6de6fa9982aaa8a4585ba

Screenshot Comparison

PR #5669 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant