c/c++: add env function wrappers for each platform

[ReenigneArcher]

Is there an existing issue for this item?

• I have searched the existing issues

Repositories

LizardByte/Sunshine

Languages/Skills/Technologies

C, C++

Description

See the following:

• https://sonarcloud.io/project/issues?open=AZ36PpMnwQuoEp6UcDge&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZ31syh33yG1EEAjNJ_4&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZ31syh33yG1EEAjNJ_5&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZv2JK3l0Tcg7JADilWW&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZv2JK3l0Tcg7JADilWX&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZv2JK3l0Tcg7JADilWY&id=LizardByte_Sunshine
• https://sonarcloud.io/project/issues?open=AZv2JK3l0Tcg7JADilWa&id=LizardByte_Sunshine

LizardByte/Sunshine#5211

Estimated Effort

effort:Small

Priority

priority:High

Target Milestone

1-3 months

Dependencies

No response

[ReenigneArcher]

Likely applies to tray and libdispalydevice as well... Maybe we need a lizardbyte-common-c library.

[Kishi85]

I've put up #5230 for the Sunshine Linux changes.

For Linux tray since it's now using Qt necessary environment variable access is done via Qt's functions to get the required QString objects natively.

[ReenigneArcher]

I've put up #5230 for the Sunshine Linux changes.

For Linux tray since it's now using Qt necessary environment variable access is done via Qt's functions to get the required QString objects natively.

I want to think about this a bit more, but my initial thought is we need a common library to use.

https://github.com/search?q=org%3ALizardByte+setenv++NOT+is%3Aarchived+language%3AC%2B%2B&type=code&l=C%2B%2B

I know it's stupid to have a library for just env functions which are suposed to be standard, but of course with c++ the standard is too dependent on the host and compiler used. It's already spiraling with just 3 c/c++ repos, and we're about to add another (libvirtualdisplay).

I think a bunch of common patterns can be added to a common repo, such as env handling, common test patterns, and maybe more.

[ReenigneArcher]

I've created https://github.com/LizardByte/lizardbyte-common but so far only has common python scripts. I will work on adding the c/c++ base setup soon.