Skip to content

feat: classic layout by default + upstream dev sync (228e9095ba) - #13

Merged
LogicLyra merged 3 commits into
mainfrom
classic-default-upstream-sync
Sep 14, 2026
Merged

LogicLyra merged 3 commits into
mainfrom
classic-default-upstream-sync

Conversation

@LogicLyra

Copy link
Copy Markdown
Owner

feat: classic layout by default + upstream dev sync

Summary

Two changes on top of PR #12:

  1. Default to the classic layout. Fresh profiles, unclassified launches,
    and eligible-without-preference users now start on classic on every
    channel (dev/beta/prod). First launches no longer auto-migrate to the new
    layout (genuine upgrades from before the 1.17.19 cutoff still do, matching
    upstream). The new layout remains one toggle away in Settings for everyone.
  2. Merge newest upstream: anomalyco/opencode dev @
    228e9095ba3988a02664c3816cb51f98584e86c2 (1 commit past PR sync: upstream v1.18.30 -- classic layout preserved, maintenance resumed #12's base:
    Merge Gateway provider logo, fix(ui): add Merge Gateway logo anomalyco/opencode#42015).

Structure

  • Merge commit b5bd7793e1: pure merge, parents 6239d706f6 (fork main)
    • 228e9095ba (upstream). Zero conflicts.
  • Fork patch commit eccb2d7664:
    • settings.tsx: newLayoutDesignsDefault = false,
      legacyNewLayoutDesignsDefault = false (classic splash on every channel),
      shouldEnableNewLayout returns false when no previous version was
      recorded (no first-launch auto-migration)
    • settings.test.ts: two assertions aligned with fork policy
    • en.ts: toggle copy drops upstream's "for a limited time" sunset
      phrasing -- in this fork layouts switch anytime
    • README fork block and AppStream metainfo generator now describe
      classic-by-default (verified inside the built deb's metainfo)

Behavior matrix after this PR

User Result
Fresh install Classic (was: new layout)
Existing classic user upgrading Stays classic (unchanged)
Existing new-layout user Stays new layout (preference wins, unchanged)
Anyone, anytime Settings toggle switches layouts, no sunset, no notice

Description/metadata audit (owner question: "update any descriptions?")

  • README fork notice: updated (classic-by-default wording)
  • AppStream metainfo (software-center summary/description): updated, verified
    in the packaged deb
  • Desktop package description: already fork-accurate ("Classic desktop
    interface for the OpenCode coding agent"), unchanged
  • Settings toggle copy (en): updated; translated locales retain upstream's
    sunset-era phrasing until retranslated (documented translation lag, same
    precedent as prior syncs)
  • Private dev docs updated post-merge

Validation

  • Full Linux package gate on the QA VM: PASS, all 10 stages (run
    20260914T160011Z-eccb2d76-package1, 16:00-16:26Z) including
    desktop-build and package-linux with fork updater metadata.
  • Settings unit tests: 15/15. App + desktop typecheck clean. oxlint: 0 errors
    on touched files.
  • Runtime visual gate: standing VM no-AVX limitation (unchanged since PR chore: sync upstream dev through 4438f69aac #6).

MatthewFeroz and others added 3 commits September 14, 2026 02:16
- fresh profiles and unclassified launches start on the classic layout on
  every channel; the new layout remains one toggle away in Settings
- first launches no longer auto-migrate to the new layout (genuine
  upgrades from before the 1.17.19 cutoff still do)
- settings copy drops the upstream 'limited time' sunset phrasing
- README and AppStream metainfo describe the classic-by-default fork
@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eccb2d7664

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"settings.general.row.newInterface.badge": "New",
"settings.general.row.newInterface.description":
"Use the new tabs and home layout. Switch between layouts for a limited time.",
"Use the new tabs and home layout. Switch between layouts anytime.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update non-English layout availability copy

When the app uses any non-English locale, its dictionary overrides this key with the old claim that switching is available only for a limited time (for example de.ts:793-794, es.ts:970-971, and zh.ts:941), so those users receive incorrect guidance despite the toggle now being permanently available. Update those translations, or temporarily remove their overrides so they fall back to the corrected English source.

AGENTS.md reference: packages/app/AGENTS.md:L35-L35

Useful? React with 👍 / 👎.

@LogicLyra
LogicLyra merged commit f5b15e5 into main Sep 14, 2026
7 of 12 checks passed
@LogicLyra
LogicLyra deleted the classic-default-upstream-sync branch September 14, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants