Conversation
avelino
reviewed
Jul 22, 2024
There was a problem hiding this comment.
I don't like calling the same function twice in an if condition, using if in parameters is common in Kotlin
startForeground(
ONGOING_NOTIFICATION_ID,
notification,
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) FOREGROUND_SERVICE_TYPE_LOCATION else 0
)ref https://developer.android.com/develop/background-work/services/foreground-services#start
|
Does it actually fix #954? I have a project of my own that faces the same issue on Samsung devices running Android 14 and the |
Lyokone
added a commit
that referenced
this pull request
Jul 14, 2026
Android 14 (API 34) throws when a foreground service starts without declaring a type. Uses ServiceCompat.startForeground with FOREGROUND_SERVICE_TYPE_LOCATION on API 29+ and declares the FOREGROUND_SERVICE / FOREGROUND_SERVICE_LOCATION permissions in the plugin manifest so background location works on modern Android (#970).
This was referenced Jul 17, 2026
Owner
|
Thanks for this. Closing as superseded — setting the foreground service type is already handled in the current Kotlin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR include foreground service type
FOREGROUND_SERVICE_TYPE_LOCATIONat runtime, the Android SDK 34 requires it.Fix #924 and #954