Skip to content

First Catch2 tests for structural 2D elements - #80

Merged
jdeaton merged 4 commits into
masterfrom
feature/catch2-tests-2d-elements
Mar 14, 2020
Merged

jdeaton merged 4 commits into
masterfrom
feature/catch2-tests-2d-elements

Conversation

@jdeaton

@jdeaton jdeaton commented Feb 19, 2020 •

Copy link
Copy Markdown
Member

This PR completes the chain of additions of Catch2 tests (#60, #70, #79) for existing MAST library capability that was originally primarily implemented by @JohnDN90. The additions here are related to 2D structural elements.

Below is a checklist of commits implemented by @JohnDN90 in his add_catch2_tests branch the whose contents/functionality need rolled in. The checklist ones will be covered in this PR:

@manavbhatia

Copy link
Copy Markdown
Member

Just curious why there appear to be the same changes introduced in #79 and #80.

@jdeaton

jdeaton commented Feb 19, 2020

Copy link
Copy Markdown
Member Author

Just curious why there appear to be the same changes introduced in #79 and #80.

It will go away here shortly. I wanted to get this up early while John was fixing something else over in #79. Once I merge #79 into master I'll rebase this branch on-top of the updated master and force push back to GitHub. It will wipe out those duplicated commits in this PR.

@jdeaton
jdeaton force-pushed the feature/catch2-tests-2d-elements branch from ed9b230 to a2c3e46 Compare February 19, 2020 18:03
@jdeaton
jdeaton force-pushed the feature/catch2-tests-2d-elements branch from a2c3e46 to 122fe0c Compare March 14, 2020 02:33
@jdeaton
jdeaton marked this pull request as ready for review March 14, 2020 03:19
@jdeaton

jdeaton commented Mar 14, 2020 •

Copy link
Copy Markdown
Member Author

Merging this one now as it completes refactoring of John's initial catch tests to reduce code duplication. There is still more testing required for 2D structural elements, but it can be added later.

@jdeaton
jdeaton merged commit c642e53 into master Mar 14, 2020
@jdeaton
jdeaton deleted the feature/catch2-tests-2d-elements branch March 14, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants