Repository navigation
Conversation
|
@ugoocreates-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Nice work! Well done |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1101
Description
This PR implements outbound DNS rebinding protection across the GasGuard repository as part of the production-readiness and long-term maintainability roadmap.
It introduces a custom HTTP/HTTPS agent (
createSafeAgent) insrc/security/dns.tsthat overrides the defaultdns.lookupfunction. By validating the resolved IP address before the connection is made, it ensures that outbound requests do not connect to private, loopback, or internal IP addresses (thereby protecting against both DNS rebinding attacks and SSRF).Changes
src/security/dns.ts: AddedisPrivateIPandcreateSafeAgentto enforce DNS resolution constraints.src/security/dns.spec.ts: Added comprehensive unit tests for normal, boundary, and failure scenarios.src/integrations/github/github-client.ts: Updated Axios to use the safe HTTP and HTTPS agents.src/simulation/stellar/stellar-rpc-client.ts: Updated Axios configuration to use the safe agents.src/modules/gas-spike-alert/webhook-dispatcher.service.ts: Replaced standardfetchwithaxiosusing the safe agents to protect outbound webhook dispatches.Verification